ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: [PATCH] ZipFileSet relative to project dir
Date Mon, 02 Apr 2001 06:52:47 GMT
David Rees <d.rees.l@usa.net> wrote:

> On 29 Mar 2001 12:24:29 +0200, Stefan Bodewig wrote:
> 
>>David Rees <d.rees.l@usa.net> wrote:
>>
>>> Fixes minor problem in ZipFileSet in so that it is relative to
>>> project dir - not working dir
>>
>>does this have any effect? I mean, is the dir attribute used at all
>>in this case?
> 
> FileSet.setDir() actually tests the File so it does get accessed (if
> not "used").

It used to, I moved the check - probably after you've submitted your
patch - to the getDirectoryScanner method.

> I came across it because in some rare cases VisualAge will run code
> in a non-existent working directory. In these cases the tests will
> fail because "." doesn't exist.

Strange behavior.

> However, the real reason I thought it was worth posting was that
> directories should always be relative to the build file. Even if
> directory is not being used for much (yet?).

I'm going to buy this 8-)

Stefan

Mime
View raw message