ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Donald <dona...@apache.org>
Subject Re: [REVIEW/SUBMIT] Pattern-matching optimization
Date Wed, 04 Apr 2001 00:14:30 GMT
At 06:54  3/4/01 -0400, Eric Siegerman wrote:
>> But I am worried because this is such a core part of the
>> system. My belief is that for such a core piece that it is preferable
>> to accept a "uglier" solution that makes less changes than a cleaner
>> one that makes more.
>
>I don't find this compelling.  Maybe it's just that I've been
>reading Martin Fowler's "Refactoring" book :-)  With unit tests,
>he says, such caution should be unnecessary.  That's why I wrote
>so many -- and why, when some of them failed, I asked for help in
>deciding whether it was the code or the tests that needed fixing.
>Nobody's commented on that yet, btw -- I guess I picked a bad
>week to ask, what with all the voting etc. going on...

If it was just us then that would be fine but to be honest we don't know
who else has extended the classes and how they did it (and many have). Thus
changing something that will break their builds is probably not a good thing.

Cheers,

Pete

*-----------------------------------------------------*
| "Faced with the choice between changing one's mind, |
| and proving that there is no need to do so - almost |
| everyone gets busy on the proof."                   |
|              - John Kenneth Galbraith               |
*-----------------------------------------------------*


Mime
View raw message