Return-Path: 
 <ant-dev-return-12284-apmail-jakarta-ant-dev-archive=jakarta.apache.org@jakarta.apache.org>
Delivered-To: apmail-jakarta-ant-dev-archive@jakarta.apache.org
Received: (qmail 46684 invoked by uid 500); 30 Mar 2001 14:56:11 -0000
Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: ant-dev@jakarta.apache.org
list-help: <mailto:ant-dev-help@jakarta.apache.org>
list-unsubscribe: <mailto:ant-dev-unsubscribe@jakarta.apache.org>
list-post: <mailto:ant-dev@jakarta.apache.org>
Delivered-To: mailing list ant-dev@jakarta.apache.org
Received: (qmail 46618 invoked from network); 30 Mar 2001 14:56:07 -0000
Message-ID: <502326F46B08D41191C400508B6D70C1014B0273@nvision01.rubus.com>
From: Les Hughes <leslie.hughes@rubus.com>
To: "'ant-dev@jakarta.apache.org'" <ant-dev@jakarta.apache.org>
Subject: RE: [Patch] New task: <p4counter>
Date: Fri, 30 Mar 2001 15:07:44 +0100
MIME-Version: 1.0
X-Mailer: Internet Mail Service (5.5.2650.21)
Content-Type: text/plain;
	charset="iso-8859-1"
X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N


Hi,

Looks cool but two things.

1) <p4counter counter="change"/> doesn't seem to work as you've not created
a setCounter method but I think this is just a typo in your javadoc maybe?
<p4counter name="foo" value="123"/> works just fine.

2) Could you update the Perforce tasks manual and post a diff for one of the
committers to erm, commit....

Bye,

Les

(BTW, you don't need to re-work P4Handler to grab the counter number into a
prop, use an anon inner class derived from P4HandlerAdapter, see P4Change
for an example.)

> -----Original Message-----
> From: Kirk Wylie [mailto:kirk@radik.com]
> Sent: 29 March 2001 16:25
> To: ant-dev@jakarta.apache.org
> Subject: [Patch] New task: <p4counter>
> 
> 
> The attached patch, along with the source file attached, will 
> implement a
> new task, <p4counter>, which will get and/or set a perforce counter.
> (perforce counters are extremely useful for automated build 
> environments).
> 
> The second file goes in
> jakarta-ant/src/main/org/apache/tools/ant/taskdefs/optional/pe
> rforce (I
> didn't know how to do "cvs diff" such that it would include 
> that file in
> the diff, if someone else knows that would be great).
> 
> Please let me know if there's another command I should be 
> using to produce
> diffs, I just did "cvs -z6 diff -u" to produce this.
> 
> Kirk Wylie
> 
> -- 
> Kirk Wylie  |  mailto:kirk@radik.com  |  http://www.radik.com
>