Return-Path: Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm Delivered-To: mailing list ant-dev@jakarta.apache.org Received: (qmail 16541 invoked from network); 7 Feb 2001 01:10:53 -0000 Received: from unknown (HELO mblfw3.macquarie.com.au) (203.28.95.251) by h31.sny.collab.net with SMTP; 7 Feb 2001 01:10:53 -0000 Received: by mblfw3.macquarie.com.au; id MAA13492; Wed, 7 Feb 2001 12:10:24 +1100 Received: from mblfw4(203.18.209.231) by mblfw3.macquarie.com.au via smap (V4.2) id xma010222; Wed, 7 Feb 01 12:06:58 +1100 Received: by mblfw4.macquarie.com.au; id MAA17026; Wed, 7 Feb 2001 12:06:56 +1100 Received: from isdserv3.macbank(10.123.0.32) by mblfw4.macquarie.com.au via smap (V4.2) id xma015292; Wed, 7 Feb 01 12:05:17 +1100 Received: from nt_syd_ex01.macbank (nt_syd_ex01 [10.124.15.10]) by isdserv3.macbank (8.9.1/8.9.1) with ESMTP id MAA08271 for ; Wed, 7 Feb 2001 12:05:15 +1100 (EST) Received: by nt_syd_ex01.macbank with Internet Mail Service (5.5.2650.21) id <13C31GDL>; Wed, 7 Feb 2001 12:05:14 +1100 Message-ID: <67FE02381F67D3119F960008C7845A2C0201CF5D@nt_syd_ex09.macbank> From: Tim Vernum To: "'ANT-dev'" Subject: [PATCH] Add "includefile" element to patternset/fileset Date: Wed, 7 Feb 2001 12:05:07 +1100 X-Mailer: Internet Mail Service (5.5.2650.21) X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N Patch ==== This patch allows patternset/fileset to accepts a "" sub-element. (and also excludefile) The works much like except it uses the logic from includesfile=.... In order to support this I had to make a few changes to the way patternset works, and I think that it ends up being quite a bit cleaner. The includefile element supports 4 attributes. file = if = unless = commentchar = The commentchar allows you to specify a character that marks a comment in the patternfile. The default is to have no comments. I was tempted to make it a commentstring, but I thought that my be overkill. This is my first patch to ant, so I'd appreciate comments/reviews. Reason for patch ============ I'm writing a fairly generic build file for a number of projects in development. Most of the build process is run by properties. I want to allow developers to includes a list of jar files, for inclusion in a WAR. This list will be in a file and will specified as a property. The should only be processed in that property is set. ie, I need the "if" support that is only available in a sub-element, and not as a direct attribute on patternset. Also I want developers to be able to comment these include files, as they will form part of the build process that will be versioned (etc). All of that is for my personal projects, but I imagine that others will have similar needs. I certainly think that being able to comment includefiles is an important change. begin 600 includefile.diff M+2TM($9I;&53970N:F%V82YO2!I;B!T:&4@9&5F875L="!P871T97)NPT**R`@("`@("`@("`@('1H&-L=61E(&QI2!I;B!T:&4@9&5F875L="!P871T97)N&-L=61E9FEL90T* M*R`@("`@*B!`PT**R`@("`@ M("`@("`@('1H&-L=61E3&ES="`](&YE=R!696-T;W(H*3L-"B`@ M("`@#0HM("`@('!R:79A=&4@1FEL92!I;F-L(#T@;G5L;#L-"BT@("`@<')I M=F%T92!&:6QE(&5X8VP@/2!N=6QL.PT*+0T*("`@("`O*BH-"BT@("`@("H@ M:6YN97(@8VQA&ES=&5N8V4@;V8@82`-"B`@("`@("H@<')O<&5R='D@*'1Y<&EC86QL M>2!S970@=&AR=2!T:&4@=7-E(&]F('1H92!!=F%I;&%B;&4@=&%S:RDN#0H@ M("`@("`J+PT*+2`@("!P=6)L:6,@8VQAPT*("`@("`@("`@("`@(&EF0V]N9"`](&-O;F0[#0H@("`@("`@ M("!]#0I`0"`M,3`U+#$U("LY."PR-2!`0`T*("`@("`@("`@("`@('5N;&5S MPT*+2`@("`@("`@("`@(')E='5R;B!N86UE M.PT**PDO*BH@4')O=FED97,@86X@87)R87D@;V8@&-E<'1I;VX[#0H@#0HM("`@("`@("!PPT**R`@ M("`@("`@<')I=F%T92!3=')I;F<@;F%M93L-"BL-"BL@("`@("`@('!U8FQI M8R!V;VED('-E=$YA;64H4W1R:6YG(&YA;64I('L@#0HK("`@("`@("`@("`@ M=&AI&-E M<'1I;VX@>R`-"BL@("`@("`@("`@("!3=')I;F=;72!R97-U;'0@/2![(&YA M;64@?3L-"BL@("`@("`@("`@("!R971UPT**R`@("`@("`@("`@('1H:7,N M8V]M;65N=$-H87(@/2!C;VUM96YT0VAA&-E<'1I;VX@ M>R`-"BL@("`@("`@("`@("!I9B@A9FEL92YE>&ES=',H*2D@>PT**R`@("`@ M("`@("`@("`@("!T:')O=R!N97<@0G5I;&1%>&-E<'1I;VXH(")0871T97)N M(&9I;&4@(B`K(&9I;&4N9V5T06)S;VQU=&50871H*"D@#0HK("`@("`@("`@ M("`@("`@("`@("`@("`@("`@("`@("`@("`@("`@("`@*R(@9&]E2![#0HK("`@("`@("`@("`@("`@($)U9F9EPT**R`@("`@("`@("`@("`@("`@("`@("`@('-K:7`@/2!F86QS M92`[#0HK("`@("`@("`@("`@("`@("`@("!]#0HK("`@("`@("`@("`@("`@ M("`@("!E;'-E(&EF*"!C;VUM96YT0VAAPT**R`@("`@ M("`@("`@("`@("`@("`@("`@(&QI;F4@/2!0&-E<'1I;VXH;7-G+"!I M;V4I.PT**R`@("`@("`@("`@('T-"BL-"BL@("`@("`@("`@("!3=')I;F<@ MPT*("`@("`@("`@PT**R`@("`@("`@("`@('1HPT*("`@("`@("`@("`@('1H&-L=61E3&ES="D[#0HK("`@("`@("!R971U M&-L=61E(&QIPT**R`@("`@("`@("`@('1H2!A9&10871T97)N5&],:7-T*%9E8W1O M2@I.PT*("`@("`@("`@;&ES="YA9&1% M;&5M96YT*')E2!A9&1&:6QE4&%T=&5R;E1O3&ES="A696-T;W(@;&ES="D@>PT**R`@ M("`@("`@1FEL945N=')Y(')E&-E<'1I;VXH(DEN8VQU9&5S9FEL92`B*VEN8VPN9V5T06)S;VQU M=&50871H*"D-"B`@("`@("`@("`@("`@("`@("`@("`@("`@("`@("`@("`@ M("`@("LB(&YO="!F;W5N9"XB*3L-"B`@("`@("`@("!]#0HM("`@("`@("`@ M=&AI&-L.PT**R`@("`@("`@(&-R96%T945X8VQU9&5F:6QE M*"DN&-L*3L-"B`@("`@('T-"B`@("`@#0H@("`@("\J*@T* M+2`@("`@*B`@4F5A9',@<&%T:"!M871C:&EN9R!P871T97)N2!I;B!T:&4@87!PPT*+2`@("`@("`@("`@("`@("!I9B`H;&EN92YL96YG M=&@H*2`^(#`I('L-"BT@("`@("`@("`@("`@("`@("`@(&QI;F4@/2!02!E>&ES M="!A="!T:&%T('!O:6YT(&EN('1I;64N(%1H92!R969EPT*0$`@+3(Y."PW("LS.30L-B!`0`T*("`@("`@("`@:68@ M*&ES4F5F97)E;F-E*"DI('L-"B`@("`@("`@("`@("!R971UPT*("`@("`@("`@("`@(')E='5R;B!G9712968H<"DN M9V5T17AC;'5D95!A='1E2AE>&-L=61E3&ES="P@<"D[#0H@("`@("`@("!]#0H@("`@ M('T-"D!`("TS,3DL."`K-#$S+#<@0$`-"B`@("`@("H@:&5L<&5R(&9O&-L=61E3&ES="YS:7IE*"D@/B`P.PT**R`@("`@("`@F4H*2`^(#`@?'P@97AC;'5D94QI2!E;&5M96YTF4H*2`] M/2`P*2!R971U2!P92`]("A0871T97)N16YT4EN=&\H&-L=61E9FEL M92!I9B!N;W0@86QR96%D>2!D;VYE('-O+@T*+2`@("`@*B\-"BT@("`@<')I M=F%T92!V;VED(')E861&:6QEPT*+2`@("`@("`@("`@(')E8610871T97)N&-L+"!E>&-L=61E3&ES M="P@<"D[#0HM("`@("`@("`@("`@97AC;"`](&YU;&P[#0HM("`@("`@("!] 1#0HM("`@('T-"BT-"B!]#0H= ` end