Return-Path: Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm Delivered-To: mailing list ant-dev@jakarta.apache.org Received: (qmail 36496 invoked from network); 5 Feb 2001 15:02:31 -0000 Received: from patan.sun.com (192.18.98.43) by h31.sny.collab.net with SMTP; 5 Feb 2001 15:02:31 -0000 Received: from sunpraha.Czech.Sun.COM ([129.156.76.4]) by patan.sun.com (8.9.3+Sun/8.9.3) with ESMTP id HAA14542 for ; Mon, 5 Feb 2001 07:02:31 -0800 (PST) Received: from netbeans.com (dhcp41 [129.156.76.41]) by sunpraha.Czech.Sun.COM (8.9.3+Sun/8.9.3/ENSMAIL,v2.1) with ESMTP id QAA08053 for ; Mon, 5 Feb 2001 16:02:24 +0100 (CET) Sender: jglick@sunpraha.Czech.Sun.COM Message-ID: <3A7EC099.7A6AF898@netbeans.com> Date: Mon, 05 Feb 2001 16:02:49 +0100 From: Jesse Glick Organization: Sun Microsystems / NetBeans X-Mailer: Mozilla 4.76 [en] (X11; U; Linux 2.2.12-20 i686) X-Accept-Language: en MIME-Version: 1.0 To: ant-dev@jakarta.apache.org Subject: Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant BuildException.java References: <20010203140632.78203.qmail@apache.org> Content-Type: multipart/mixed; boundary="------------D73B422F06C5B4C05DF6361A" X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N --------------D73B422F06C5B4C05DF6361A Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit conor@apache.org wrote: > Modified: src/main/org/apache/tools/ant BuildException.java > Log: > Change buildException to always print nested exceptions when printing > its stack trace. Removed the equivalent code from DefaultLogger. Did you also mean to commit a patch to DefaultLogger? If so, it got missed... attached for reference. -Jesse -- Jesse Glick NetBeans, Open APIs tel (+4202) 3300-9161 Sun Micro x49161 Praha CR --------------D73B422F06C5B4C05DF6361A Content-Type: text/plain; charset=us-ascii; name="defaultlogger.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="defaultlogger.diff" Index: src/main/org/apache/tools/ant/DefaultLogger.java =================================================================== RCS file: /home/cvspublic/jakarta-ant/src/main/org/apache/tools/ant/DefaultLogger.java,v retrieving revision 1.13 diff -u -r1.13 DefaultLogger.java --- src/main/org/apache/tools/ant/DefaultLogger.java 2001/01/11 12:13:02 1.13 +++ src/main/org/apache/tools/ant/DefaultLogger.java 2001/02/05 15:00:25 @@ -137,18 +137,7 @@ } else { err.println(lSep + "BUILD FAILED" + lSep); - - if (error instanceof BuildException) { - err.println(error.toString()); - - Throwable nested = ((BuildException)error).getException(); - if (nested != null) { - nested.printStackTrace(err); - } - } - else { - error.printStackTrace(err); - } + error.printStackTrace(err); } out.println(lSep + "Total time: " + formatTime(System.currentTimeMillis() - startTime)); --------------D73B422F06C5B4C05DF6361A--