ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simeon H.K. Fitch" <simeon.fi...@mseedsoft.com>
Subject RE: [SUBMISSION] Antidote: DependTargetPropertyEditor
Date Mon, 19 Feb 2001 14:00:51 GMT
Christoph,

I have checked in your submission. Well done, sir! Excellent code! I hope
I looked at it fast enough for you ;-).

Please externalize the strings as soon as you can. That's one of those
things I like to have done before checkin.

I'm not sure I understand #3 on the "TODO:" list?

Again, Thanks,

Simeon

> -----Original Message-----
> From: Christoph Wilhelms [mailto:Christoph.Wilhelms@t-online.de]
> Sent: Monday, February 19, 2001 12:56 AM
> To: ant-dev@jakarta.apache.org
> Subject: [SUBMISSION] Antidote: DependTargetPropertyEditor
>
>
> Hi Simeon (and everyone else interested in Antidote)!
>
> Phew! Finally I did it - or even hope to ;-).
>
> Attending to your last mail, I - in fact - just had to
> update ACSTargetElement and it's BeanInfo. I think
> I understand your "Generic" architecture now (BTW:
> undocumented it's not REALLY userfriendly ;-).
> Probably we should write a "HOW TO" building
> custom-editors) - this will help me developing
> future property-editor. At the time I have a
> task-chooser in mind!
>
> I hope I did everthing right, please tell me if you
> find something to make more Simeon-style ;-). Tried
> to use the same codingstyle you did, well really
> "tried to"!
>
> I attached to .diff files for ACSTargetElement.java and
> ACSTargetElementBeanInfo.java. If the diff did not
> work they are (as comlete files) included in the .ZIP
>
> The .ZIP includes 3 new classes for the module.edit
> packsge and 3 new icons in .ressources
>
> It was a lot of work, so *please* take a look at it
> quickly ;-).
>
> TODO:
> 1. Make dialog more "keyboard-friendly".
> 2. externalize strings to resource-file
> 3. check referenzing of the images
>
> I'll deal with 1. after "ommit" ;-). For 2. and 3.
> it would be nice if you (Sim) can take a look at it -
> shouldn't take long *g*!
>
> Ok, enough for now!
>
> Good Night!
> Chris

Mime
View raw message