BugRat Report # 801

Project: Ant Release: 1.0
Category: Feature Requests SubCategory: Enhancement
Class: suggest State: received
Priority: high Severity: serious
Confidence: public

Submitter: Rusty Knabe ( rusty.knabe@infosphere.com )
Date Submitted: Jan 18 2001, 11:31:05 CST
Responsible: Z_Ant Alias ( ant-bugs@cortexity.com )

Synopsis:
slight change in CompareTagBase makes much more extensible
Environment: (jvm, os, osrel, platform)
1.22_06, Win NT, 4.0 SP 6a, Any

Additional Environment Description:

Report Description:
Breaking the code up in the condition(int, int) method in CompareTagBase.java makes class more extensible. In the code starting with: Object variable = null; if cookie != null { Down to and including the end of the if..else chain. Just before : "if (variable == null) {" Please move that code into a protected method such as getVariable(). The result could also be cached into a private variable to avoid redundant work. In my case, it is very easy to write Switch and Case tags by extending this class much like Equals and other logic tags. Would be willing to contrib these.

View this report online...