ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Josh Lucas <j...@stonecottage.com>
Subject Re: [PATCH] Re: other tokens
Date Thu, 18 Jan 2001 02:44:38 GMT
Honestly, my initial thought was how to add this 'feature' with a
minimal amount of pain. 

To factor out copy functionality from Project would be great and
something which would be quite useful.  I submitted this patch as a way
for this to work since I was somewhat surprised that you couldn't
specify the token.

It seems that I was a bit premature in my choice of implementation as I
would agree that Target isn't the best place for this info.

I have no problems with that patch being rolled back and I will look at
moving that functionality into the filter task though changes to Project
will be necessary.


josh


Conor MacNeill wrote:
> 
> Jon,
> 
> It appears that you have reformatted the files a little here - I guess that
> was intentional. Rather than wading through that, I'll assume you committed
> the patch exactly as Josh submitted it.
> 
> I'm not that keen on this. The patch lets you specify a token attribute at
> the target level. What does copy filtering have to do with a target, really?
> As well, the target just sets the value on the project object. I think the
> whole copy functionality should be refactored out of Project, perhaps into
> <copy>
> 
> Why not make this token attribute an attribute of copy, along with a nested
> filter element, so filtering can become more explicit in operation.
> Something like
> 
> <copy tokendelimiter="%" ...>
>    <filter token="year" value="2000"/>
> </copy>
> 
> Of course, we would still support the current "global" filters implicitly.
> 
> If we let this go ahead now, we create a backward compatibility issue later
> on.
> 
> Thoughts?
> 
> Conor
> 
> --
> Conor MacNeill
> conor@cortexebusiness.com.au
> Cortex eBusiness
> http://www.cortexebusiness.com.au
> 
> > -----Original Message-----
> > From: Jon Stevens [mailto:jon@latchkey.com]
> > Sent: Thursday, 18 January 2001 12:45
> > To: ant-dev@jakarta.apache.org
> > Subject: Re: [PATCH] Re: other tokens
> >
> >
> > on 1/17/01 5:20 PM, "Josh Lucas" <josh@stonecottage.com> wrote:
> >
> > > here ya go...
> >
> > I just checked this in. could you also please update the index.html?
> >
> > thx.
> >
> > -jon
> >
> > --
> > Honk if you love peace and quiet.
> >

Mime
View raw message