ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From BugRat Mail System <tomcat-b...@cortexity.com>
Subject BugRat Report #801 has been filed.
Date Thu, 18 Jan 2001 17:31:05 GMT
Bug report #801 has just been filed.

You can view the report at the following URL:

   <http://znutar.cortexity.com/BugRatViewer/ShowReport/801>

REPORT #801 Details.

Project: Ant
Category: Feature Requests
SubCategory: Enhancement
Class: suggest
State: received
Priority: high
Severity: serious
Confidence: public
Environment: 
   Release: 1.0
   JVM Release: 1.22_06
   Operating System: Win NT
   OS Release: 4.0 SP 6a
   Platform: Any

Synopsis: 
slight change in CompareTagBase makes much more extensible

Description:
Breaking the code up in the condition(int, int) method in CompareTagBase.java makes class
more extensible.

In the code starting with:
 Object variable = null;
 if cookie != null {

Down to and including the end of the if..else chain. Just before : "if (variable == null)
{"

Please move that code into a protected method such as getVariable(). The result could also
be cached into a private variable to avoid redundant work. 

In my case, it is very easy to write Switch and Case tags by extending this class much like
Equals and other logic tags. Would be willing to contrib these.

Mime
View raw message