ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Diane Holt <hol...@yahoo.com>
Subject RE: [PATCH] Re: other tokens
Date Thu, 18 Jan 2001 02:19:07 GMT
I agree. I was also confused by where this got changed. I like your idea
of a nested <filter> element for <copy> -- I've also been wanting one
other thing for filtering as well, and that is that the filtersfile be
allowed to reference properties for the replacement value.

Diane

--- Conor MacNeill <conor@cortexebusiness.com.au> wrote:
> Jon,
> 
> It appears that you have reformatted the files a little here - I guess
> that
> was intentional. Rather than wading through that, I'll assume you
> committed
> the patch exactly as Josh submitted it.
> 
> I'm not that keen on this. The patch lets you specify a token attribute
> at
> the target level. What does copy filtering have to do with a target,
> really?
> As well, the target just sets the value on the project object. I think
> the
> whole copy functionality should be refactored out of Project, perhaps
> into
> <copy>
> 
> Why not make this token attribute an attribute of copy, along with a
> nested
> filter element, so filtering can become more explicit in operation.
> Something like
> 
> <copy tokendelimiter="%" ...>
>    <filter token="year" value="2000"/>
> </copy>
> 
> Of course, we would still support the current "global" filters
> implicitly.
> 
> If we let this go ahead now, we create a backward compatibility issue
> later
> on.
> 
> Thoughts?
> 
> Conor
> 
> --
> Conor MacNeill
> conor@cortexebusiness.com.au
> Cortex eBusiness
> http://www.cortexebusiness.com.au
> 
> > -----Original Message-----
> > From: Jon Stevens [mailto:jon@latchkey.com]
> > Sent: Thursday, 18 January 2001 12:45
> > To: ant-dev@jakarta.apache.org
> > Subject: Re: [PATCH] Re: other tokens
> >
> >
> > on 1/17/01 5:20 PM, "Josh Lucas" <josh@stonecottage.com> wrote:
> >
> > > here ya go...
> >
> > I just checked this in. could you also please update the index.html?
> >
> > thx.
> >
> > -jon
> >
> > --
> > Honk if you love peace and quiet.
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: ant-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: ant-dev-help@jakarta.apache.org
> >
> >
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: ant-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: ant-dev-help@jakarta.apache.org
> 


=====
(holtdl@yahoo.com)



__________________________________________________
Do You Yahoo!?
Get email at your own domain with Yahoo! Mail. 
http://personal.mail.yahoo.com/

Mime
View raw message