ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Rosenberg" <ja...@squaretrade.com>
Subject Re: What I did to Delete.java
Date Fri, 19 Jan 2001 20:08:18 GMT
Glenn,

I agree with both you and Stefan.  Since I am generally
instantiating my Delete objects directly via javascript,
and always calling setVerbose on the object, I hadn't
properly considered all the effects of what happens
in non-verbose mode.

I would be greatful if you check in a fix.

Thanks,

Jason

----- Original Message ----- 
From: "Glenn McAllister" <glenn@somanetworks.com>
To: <ant-dev@jakarta.apache.org>
Sent: Friday, January 19, 2001 9:23 AM
Subject: Re: What I did to Delete.java


> Stefan Bodewig wrote:
> 
> > > And changed the logging in the removeDir() method to always happen,
> > > instead of just for verbose mode:
> >
> > I'm not sure I'd want that much output - this is going to print a line
> > for every single directory out of a big directory tree. IMHO this
> > should be left to verbose reporting.
> 
> I'm inclined to agree.  My suggestion is that if the "verbosity" is
> VERBOSE, skip the first message and let the removeDir method do all the
> logging.
> 
> I'm happy to fix this, but I'm going to follow Sam's lead on this one.
> :-) Anyone have any objections before I do this?
> 
> Glenn McAllister.
> 


Mime
View raw message