Return-Path: <leslie.hughes@rubus.com>
Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm
Delivered-To: mailing list ant-dev@jakarta.apache.org
Received: (qmail 44984 invoked from network); 6 Dec 2000 12:32:48 -0000
Received: from unknown (HELO nvision01.rubus.com) (194.129.19.135)
  by locus.apache.org with SMTP; 6 Dec 2000 12:32:48 -0000
Received: by nvision01.rubus.com with Internet Mail Service (5.5.2650.21)
	id <WR7CZ5QH>; Wed, 6 Dec 2000 12:29:52 -0000
Message-ID: <502326F46B08D41191C400508B6D70C1014AFD7E@nvision01.rubus.com>
From: Les Hughes <leslie.hughes@rubus.com>
To: "'ant-dev@jakarta.apache.org'" <ant-dev@jakarta.apache.org>
Subject: RE: [Patch] P4Base.java
Date: Wed, 6 Dec 2000 12:29:51 -0000 
MIME-Version: 1.0
X-Mailer: Internet Mail Service (5.5.2650.21)
Content-Type: text/plain;
	charset="iso-8859-1"
X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N

Guys,

P4Base needs to be sorted out in a bit more - it was a bit of a quick
hack.....;-)

Basically, the runtime.exec  bit of it was ripped out of 1.1's exec task but
since that all changed with 1.2 we (erm I) need to revisit. It's pointless
having OS specific exec code in two places.

Also, the exec on unix (/bin/sh p4 blah blah blah) will fail (oops, guilty
of not properly testing it...)

So, my company branch of the perforce stuff is being fixed today and I'll
try to merge these changes asap.



Les


> -----Original Message-----
> From: James Cook [mailto:jimcook@iname.com]
> Sent: 05 December 2000 18:48
> To: ant-dev@jakarta.apache.org
> Subject: Re: [Patch] P4Base.java
> 
> 
> Can't we add regexp matching, or even simpler, an indexOf() 
> check. PS. Case
> sensitivity should be removed also.
> 
> jim
> 
> ----- Original Message -----
> From: "Stefan Bodewig" <bodewig@apache.org>
> To: <ant-dev@jakarta.apache.org>
> Sent: Tuesday, December 05, 2000 11:33 AM
> Subject: Re: [Patch] P4Base.java
> 
> 
> > Craig Kelley <ckelley@HotPOP.com> wrote:
> >
> > > A patch to fix the OS check for Windows. It was looking for "nt"
> > > which only worked for Windows NT (not Windows 2000).
> >
> > But this won't work on Windows 95/98 - not that the old version did.
> >
> > Stefan
> >
>