ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Burton" <bi...@progress.com>
Subject [PATCH] fixes to ant script for cygwin
Date Thu, 21 Dec 2000 07:08:43 GMT
Hello,

Attached is a patch for improved Cygwin support in the ant script.  I
found the current version has problems because it didn't convert all the
necessary variables to UNIX format paths before the body of the script
started building up the CLASSPATH.  The end result was a JAVA_HOME that
looked something like D:\/d/jdk1.3 preventing Ant from starting.  Rather
than just fix that one problem, I reworked the cygwin support to be more
robust and easier to maintain.

This patch makes the following improvements for cygwin support:
1. Test for cygwin is done only once at the top of the script rather than
each time  conditional logic for cygwin was needed.
2. Removed calls to cygpath in the middle of the script so now they're
localized at the top and bottom.
3. The variables ANT_HOME, JAVA_HOME and CLASSPATH can be set either using
Windows or UNIX path conventions before running Ant without getting
garbled variables or CLASSPATH.
4. Spaces in any existing CLASSPATH are handled correctly.  However, I
made no attempt at handling the case where Ant or Java is installed in a
directory with spaces.  If there is consensus that needs to be fixed, I'd
be willing to come up with a separate patch to handle that case.

-Bill Burton
Mime
View raw message