ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stuart Roebuck ...@adolos.com>
Subject Re: [patch] rough Telnet Remote Command Task
Date Mon, 06 Nov 2000 16:21:42 GMT
I've quickly incorporated the Port attribute as you suggested, plus any other changes I made
since the last patch to streamline its operation (e.g. a change to cope with servers that
echo commands to the output).  I've put your suggestions into the Javadoc comment at the beginning,
and the code is littered with various suggestions on things that could/should be improved.
 However, it is working very happily for me with a number of remote telnet hosts.

I'm not too familiar with Telnet, but I would hope that there might be more elegant ways around
issues with identifying prompts and confirming that commands have completed.  But in the absence
of these I think that there may be some difficulty combining the specifics of making a remote
Telnet command work in most cases with some of your suggestions of making it more generic
for use with protocols which sit on top of Telnet.

Oh, finally, I've moved it into the optional tasks.

Hope this looks okay,

Stuart.

Index: defaults.properties
===================================================================
RCS file: /home/cvspublic/jakarta-ant/src/main/org/apache/tools/ant/taskdefs/defaults.properties,v
retrieving revision 1.49
diff -u -r1.49 defaults.properties
--- defaults.properties	2000/11/06 12:35:14	1.49
+++ defaults.properties	2000/11/06 16:09:34
@@ -67,6 +67,7 @@
 propertyfile=org.apache.tools.ant.taskdefs.optional.PropertyFile
 depend=org.apache.tools.ant.taskdefs.optional.depend.Depend
 antlr=org.apache.tools.ant.taskdefs.optional.ANTLR
+telnet=org.apache.tools.ant.taskdefs.optional.Telnet
 
 # deprecated ant tasks (kept for back compatibility)
 javadoc2=org.apache.tools.ant.taskdefs.Javadoc


The new task file ant/src/main/org/apache/tools/ant/taskdefs/optional/Telnet.java is attached
as a zip archive.


Mime
View raw message