ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jesse Tilly <JTi...@hoteltools.com>
Subject RE: Property file handler task
Date Fri, 03 Nov 2000 01:23:38 GMT
Javadoc isn't comprehensive.  The doc *inside* the code was.  Task works
beautifully.  Here are some notes I have:

(1) Just add what he's written outside of the class javadoc block to the
class block and *boom*, better documentation
(2) Not all null pointers are being caught (notably executeOn for
PropertyFile.Entry)
(3) instead of requiring an "entry" type, default to string
(4) Are we stuck to Java 1.1 or is this a Java2 tool?  If Java2, should be
making better use of collections
(5) A big nice would be that the file isn't completely rewritten , but this
would be hard.  For example, in weblogic.properties, it formats better to
have comma separated values on individual lines.  However, when PropertyFile
is done with it, every property is on one line.

I'll try to make some of these changes tonight and send a patch/diff.  I've
never done that for a project, but there's a first for everything.

Jesse
-----Original Message-----
From: Conor MacNeill [mailto:conor@ebinteractive.com.au]
Sent: Thursday, November 02, 2000 7:33 PM
To: ant-dev@jakarta.apache.org
Subject: RE: Property file handler task


The <propertyfile> task was added after the 1.2 release. Can you have a look
at it and see if it meets your needs. It is currently undocumented, so you
will have to rely on the Javadoc which is reasonably comprehensive.

Conor


--
Conor MacNeill
conor@cortexebusiness.com.au
Cortex eBusiness
http://www.cortexebusiness.com.au

> -----Original Message-----
> From: Jesse Tilly [mailto:JTilly@hoteltools.com]
> Sent: Friday, 3 November 2000 11:26
> To: 'ant-dev@jakarta.apache.org'
> Subject: Property file handler task
>
>
> Has anyone defined a task that can modify a properties file?  Something
> like:
>
> <property-handler file="weblogic.properties">
>   <property-change name="weblogic.httpd.enable" value="false"/>
> </property-handler>
>
> > J E S S E  E  T I L L Y
> > Senior Programmer, Development
> > ____________________________________________
> > HotelTools, Inc.
> > 100 Galleria Parkway, Suite 1020
> > Atlanta, GA  30339
> > ph: 770.956.4080 x5361
> > fax: 770.956.4077
> > cell: 678.524.5764
> > http://www.hoteltools.com
> >
>  <<Jesse Tilly.vcf>>
>

Mime
View raw message