ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Conor MacNeill" <co...@m64.com>
Subject RE: [PATCH] Wait and Available
Date Tue, 28 Nov 2000 20:35:35 GMT


> -----Original Message-----
> From: Jon Tirsén [mailto:jon.tirsen@emm.com]
> Sent: Wednesday, 29 November 2000 0:52
> To: ant-dev@jakarta.apache.org
> Subject: RE: [PATCH] Wait and Available
>
>
> Except for the "I" I really do like to concept.
>
> But then again I'm not either a committer or a supporter of
> the general law
> of ant: "If it's not simple it's not ant." :-)
>

Fine. What is *your* vision of ant then? :-)

> It's a bit sad that the actual discussion got drowned by a naming and
> tabbing discussion... :-(

Jon, the reason I asked Thomas about his tabs is not because I have a
particular distaste of tabs but more because of the fact that he
completely reformatted the source files making it difficult to see what
changes he had made. As a committer, I want to understand any patch I
commit to make sure it works, that it doesn't break ant, etc. To me that
is the responsibility of a committer.

I hope Thomas can resubmit the patch in a format where I can clearly
understand his changes. BTW, I would have removed the "I" anyway :-)

Conor


Mime
View raw message