ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stuart Roebuck ...@adolos.com>
Subject [Patch] Fix for Chmod on MacOS X & build location
Date Tue, 17 Oct 2000 11:11:26 GMT
Building Apache-James I've just noticed that the OS check on Chmod doesn't identify MacOS X
as a valid Unix.  Here's a patch:

Index: src/main/org/apache/tools/ant/taskdefs/Chmod.java
===================================================================
RCS file: /home/cvspublic/jakarta-ant/src/main/org/apache/tools/ant/taskdefs/Chmod.java,v
retrieving revision 1.8
diff -r1.8 Chmod.java
172c172
<             !System.getProperty("os.name").startsWith("Mac") && 
---
>             !(System.getProperty("os.name").startsWith("Mac") && !System.getProperty("os.name").endsWith("X"))
&& 



I'm also puzzled as to why the location of the build directory set in "build.xml" is set to
be outside the ant directory tree.  Here's the patch to put it back in, but I suspect I'm
missing something here and there's probably a good reason why it was set the way it is:

Index: build.xml
===================================================================
RCS file: /home/cvspublic/jakarta-ant/build.xml,v
retrieving revision 1.84
diff -r1.84 build.xml
22c22
<   <property name="build.dir" value="../build/ant"/>
---
>   <property name="build.dir" value="build/ant"/>


I've not sent any patches before, so please let me know if I'm doing anything wrong.

Cheers,

Stuart.
-------------------------------------------------------------------------
Stuart Roebuck, BSc, MBA        Tel.: 0131 228 4853 / Fax.: 0870 054 8322
Managing Director                       Alpha Numeric Pager: 07654 588898
ADOLOS                                             http://www.adolos.com/
Mime
View raw message