ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Scotte Zinn" <sz...@patronix.com>
Subject RE: [PATCH] New <case> task
Date Thu, 12 Oct 2000 22:27:19 GMT
> -----Original Message-----
> From: Diane Holt [mailto:holtdl@yahoo.com]
> Sent: Thursday, October 12, 2000 2:05 PM
> To: ant-dev@jakarta.apache.org
> Subject: Re: [PATCH] New <case> task
>
>
> --- Stefan Bodewig <bodewig@bost.de> wrote:
> >  SZ>   <!-- Load the build properties from the specified file -->
> >  SZ> <property file="${prop.name}.properties"/>
> >
> > I like this solution.
>
> I don't. How many little properties files are we supposed to
> have to stuff
> into our tree just to get around this? Why should we have a
> bunch of files
> we don't really need (and that we'll need to maintain) whose
> sole purpose
> in life is to work around a (as far as I'm concerned) rather peculiar
> limitation?

I was only showing that one could get (what Stefan describes as case
behaviour) with Ant already.  If property had the if/unless behaviour you
described, then the same effect could be achieved.  My original concern with
scripting inside a build file is that it adds to the maintenance complexity.
I agree that having a wrapper script that does all of the configuration is
just as complex.  Using <property file=...> localizes the various
configurations and is more readable than code.

By the way, expanding ${xxx} inside the depends attribute of a target would
also be a useful feature.  For example:

  <target name="init" depends="${prop.name}" if="prop.name"/>

would only execute if prop.name is defined and would execute the target
defined in prop.name.

This behaviour isn't currently there though and I'm not sure if the 'if'
attribute is checked prior to the dependency check.  Of course, prop.name
would have to be declared prior to the Ant invocation though.

>
> I'm sorry, but I just don't get it. Personally, I think this alarmist
> attitude towards a test-for-value capability is just silly. I
> also think
> I'll just go ahead and dig up the mail with the if="foo=bar" patch and
> apply it locally...I've got a list of things I already need to change
> whenever I pick up new stuff, might as well add this one to it.
>
> Diane
>
> =====
> (holtdl@yahoo.com)
>
>
>
> __________________________________________________
> Do You Yahoo!?
> Get Yahoo! Mail - Free email you can access from anywhere!
> http://mail.yahoo.com/
>


Mime
View raw message