From bodewig@bost.de Mon Sep 4 12:46:21 2000 Return-Path: Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm Delivered-To: mailing list ant-dev@jakarta.apache.org Received: (qmail 53200 invoked from network); 4 Sep 2000 12:46:21 -0000 Received: from public.ndh.net (HELO public.ndh.com) (195.94.90.21) by locus.apache.org with SMTP; 4 Sep 2000 12:46:21 -0000 Received: from sbodewig.bost.de ([195.227.98.11]) by public.ndh.com (8.9.3/8.8.0) with ESMTP id OAA13927 for ; Mon, 4 Sep 2000 14:46:17 +0200 (MET DST) Received: (from bodewig@localhost) by sbodewig.bost.de (8.9.3/8.9.3) id OAA03942; Mon, 4 Sep 2000 14:46:15 +0200 X-Authentication-Warning: sbodewig.bost.de: bodewig set sender to bodewig@bost.de using -f To: ant-dev@jakarta.apache.org Subject: Where to place stand alone data types like ? From: Stefan Bodewig Date: 04 Sep 2000 14:46:15 +0200 Message-ID: Lines: 24 User-Agent: Gnus/5.0807 (Gnus v5.8.7) XEmacs/21.1 (Capitol Reef) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N If you look at Ant's own build.xml, you can see that the PatternSet with the id "chmod.patterns" is defined in a task in target main and referenced twice later on. This makes the in main special. I feel, it would be much more natural to define the patternset somewhere outside the task and use a in the first as well. The same holds true for FileSets or PATH like structures that get used more than once. I've added infrastructure needed to have , and elements in the build.xml with my last patch. Only ProjectHelper is not aware of this yet. Given that the reference mechanism in Ant is a global one (and antstructure claims it would sit on top of the XML ID attribute type - which means the id must be unique 8^), I'd say make and friends a sibling of and only allow them to be placed there and not inside of s. This would avoid the confusion of as well. What do you think? Stefan