ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@bost.de>
Subject Re: [PATCH] Filter using properties
Date Wed, 20 Sep 2000 16:07:30 GMT
>>>>> "JD" == Jason Dillon <jason@planet57.com> writes:

 JD> On 19 Sep 2000, Stefan Bodewig wrote:

 >> (1) You don't need to check getUserProperties separately,

 JD> My apologies.

Oops, did I sound like I wanted that? Sorry, this has never been my
intention.

 >> (2) I wouldn't want to make <filter> change Project's behavior.

 JD> Do you mean the change to replace()... could you please explain.

Yes. I must admit that I don't actually like the idea of making all
properties filters - which might make it difficult to argue with me.

It is too implicit for my taste, all Java system properties are Ant
properties as well and I wouldn't want to be careful not to put
@os.name@ into any files I'm going to copy. But than again I don't
need to use the feature, I know.

 >> If you really want to make all properties filters as well, the
 >> cleaner solution seems to be to make <filter> loop over all
 >> properties and create filters from them.

 JD> This seems a bit excessive... 

It is, you are right. 

Maybe this is because the whole copying/filtering thing doesn't really
belong into Project for me. Project is part of the very core of Ant,
while copying, replacing and so on should be the responsibility of
tasks.

I mean, making all properties filters is something the filter task
should do itself, not tell Project to do so. I have no way of
explaining this better than that it doesn't feel right to me. Code
smell.

Stefan

Mime
View raw message