ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason Dillon <ja...@planet57.com>
Subject Re: [PATCH] Filter using properties
Date Wed, 20 Sep 2000 18:58:28 GMT
>  >> If you really want to make all properties filters as well, the
>  >> cleaner solution seems to be to make <filter> loop over all
>  >> properties and create filters from them.
> 
>  JD> This seems a bit excessive... 
> 
> It is, you are right. 
> 
> Maybe this is because the whole copying/filtering thing doesn't really
> belong into Project for me. Project is part of the very core of Ant,
> while copying, replacing and so on should be the responsibility of
> tasks.
> 
> I mean, making all properties filters is something the filter task
> should do itself, not tell Project to do so. I have no way of
> explaining this better than that it doesn't feel right to me. Code
> smell.

On that note... shouldn't the core filtering methods be part of a
task?  Perhaps it would be better to define a pluggable filter?

--jason


Mime
View raw message