ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason Dillon <ja...@planet57.com>
Subject Re: [PATCH] Filter using properties
Date Tue, 19 Sep 2000 18:49:08 GMT
Some comments below...

On 19 Sep 2000, Stefan Bodewig wrote:
> Some quick comments.
> 
> (1) You don't need to check getUserProperties separately, all user
> properties are included in getProperties as well.

Oh... oops =)  I did not take too close of a look at what
setUserProperty() was actually doing.  I made a poor assumption... and
didn't check it out fully.  My apologies.

Perhaps a little javadoc for getProperty() and getUserProperty() might
eliminate such mistakes in the future.

> (2) I wouldn't want to make <filter> change Project's behavior. If you
> really want to make all properties filters as well, the cleaner
> solution seems to be to make <filter> loop over all properties and
> create filters from them.

This seems a bit excessive... to take every property, which is already in
a hashtable, and copy it into another hashtable.  I am not sure what you
mean by change Project's behavior.  Do you mean the change to
replace()... could you please explain.

--jason


Mime
View raw message