ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jose Alberto Fernandez <JFernan...@viquity.com>
Subject RE: [PATCH] Print SQL to System.out or output file
Date Thu, 28 Sep 2000 18:39:35 GMT
> From: Stefan Bodewig [mailto:bodewig@bost.de]
> 
> >>>>> "JAF" == Jose Alberto Fernandez <JFernandez@viquity.com> writes:
> 
>  JAF> 1) Attributes similar to <exec>'s "os" attribute.
> 
> I'm not sure the JDBC specs are strong enough to base a decision on
> this. rdbmsvendor will probably be
> DatabaseMetadata.getDatabaseProductName. I wouldn't bet that each and
> every JDBC driver for Oracle 8 is going to return "Oracle" here, what
> would the JDBC-ODBC bridge return?
> 
> I'm not against it, I just doubt one could do it.

Well, notice that this information is retrieved once the connection is
stablish. So, it should come out of the DB and not just the driver.
I did not test the JDBC-ODBC bridge, but the oracle drivers for 8.1.6
actually tell you that the version is 8.1.5 when you are connected to an
8.1.5 db.

> 
>  JAF> 2) An attribute "onerror='continue'" the possible values being:
>  JAF> continue, stop, abort (default when autocommit off).
> 
> +1

Additionally to this I have added a new inner element <transaction>
which allows defining multiple transaction blocks using the same connection.
This is particularly usefull when the input is in multiple files and you do
not want to reconnect over and over or retype all the <sql> attributes over
and over.

I finish it last night, and I am adding the doc's before submitting the
patch. I also corrected some problems in the way comments where handled and
log messages where generated. I should be done in a couple of hours.

Jose Alberto

Mime
View raw message