ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Conor MacNeill" <co...@m64.com>
Subject RE: [PATCH] Filter task enhanced, reads filters from file.
Date Sun, 24 Sep 2000 11:19:21 GMT
Gero,

I have committed your patch. Would it be possible to send me a unified diff
for the index.html rather than the whole file. I haven't committed the
changes in that file.

Cheers
Conor


> -----Original Message-----
> From: Gero Vermaas, Sun Java Center [mailto:Gero.Vermaas@sun.com]
> Sent: Saturday, 23 September 2000 21:44
> To: ant-dev@jakarta.apache.org
> Subject: Re: [PATCH] Filter task enhanced, reads filters from file.
>
>
> You're right. Attached you find a correct version with "filtersfile"
>
> Regards,
> Gero
> ----- Original Message -----
> From: "Diane Holt" <holtdl@yahoo.com>
> To: <Gero.Vermaas@Sun.COM>
> Sent: Saturday, September 23, 2000 11:31
> Subject: Re: [PATCH] Filter task enhanced, reads filters from file.
>
>
> > --- "Gero Vermaas, Sun Java Center" <Gero.Vermaas@sun.com> wrote:
> > > I've added a "filtersfile" parameter to the Filter task.
> >
> > Hi Gero,
> >
> > Here you say it's "filtersfile", but in index.html and in the code, it's
> > "filterfile". I think it probably really should be "filtersfile", since
> > that would match "includesfile" and "excludesfile", and keep things like
> > this consistent (so people don't have to remember things like,
> "Oh right,
> > it's without the "s" in the <filter> task").
> >
> > Thanks,
> > Diane
> >
> >
> > =====
> > (holtdl@yahoo.com)
> >
> >
> >
> > __________________________________________________
> > Do You Yahoo!?
> > Send instant messages & get email alerts with Yahoo! Messenger.
> > http://im.yahoo.com/
> >
>


Mime
View raw message