Return-Path: Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm Delivered-To: mailing list ant-dev@jakarta.apache.org Received: (qmail 96281 invoked from network); 14 Jul 2000 18:32:51 -0000 Received: from unknown (HELO odo.i2.com) (64.26.226.21) by locus.apache.org with SMTP; 14 Jul 2000 18:32:51 -0000 Received: from i2.com ([10.20.81.92]) by odo.i2.com (8.9.0/8.9.0) with ESMTP id NAA21668 for ; Fri, 14 Jul 2000 13:31:32 -0500 (CDT) Message-ID: <396F5CB5.1187B7DB@i2.com> Date: Fri, 14 Jul 2000 13:32:21 -0500 From: Ken Wood Organization: DSS Production Team X-Mailer: Mozilla 4.72 [en] (WinNT; I) X-Accept-Language: en MIME-Version: 1.0 To: ant-dev@jakarta.apache.org Subject: Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/taskdefs Javadoc.java References: <20000714150237.33477.qmail@locus.apache.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Thank you! Thank you!! I was about to report this same problem! I had traced it as far as having something to do with comments, but hadn't figure out what the cause was.... On a related note, I give javadoc task a list of packagenames, and yet it persists in looking at files that are NOT in the list. Is that what I should expect to see, or is there another bug lurking?? Finally, I have a question about timing. When I see these commit messages, I assume they will be in the next day's 3:19 AM "jakarta-ant.src.zip" file... conor@locus.apache.org wrote: > conor 00/07/14 08:02:36 > > Modified: src/main/org/apache/tools/ant/taskdefs Javadoc.java > Log: > Minor bug fixes in Javadoc. > > 1. handle package statements that use tabs. > 2. Fix minor bug in comment parsing. > > The parsing bug was pointed out by Johan Granstrom but > I have not used his patch directly. > > Revision Changes Path > 1.17 +6 -1 jakarta-ant/src/main/org/apache/tools/ant/taskdefs/Javadoc.java > > Index: Javadoc.java > =================================================================== > RCS file: /home/cvs/jakarta-ant/src/main/org/apache/tools/ant/taskdefs/Javadoc.java,v > retrieving revision 1.16 > retrieving revision 1.17 > diff -u -r1.16 -r1.17 > --- Javadoc.java 2000/07/14 08:25:52 1.16 > +++ Javadoc.java 2000/07/14 15:02:33 1.17 > @@ -859,7 +859,8 @@ > log("Could not evaluate package for " + file, Project.MSG_WARN); > return null; > } > - if (line.trim().startsWith("package ")) { > + if (line.trim().startsWith("package ") || > + line.trim().startsWith("package\t")) { > name = line.substring(8, line.indexOf(";")).trim(); > break; > } > @@ -931,6 +932,10 @@ > c = in.read(); > if (c == '*') { > c = in.read(); > + while (c == '*' && c != -1) { > + c = in.read(); > + } > + > if (c == '/') { > c = read(); > break; > > >