ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Philion" <phil...@acmerocket.com>
Subject [PATCH] Minor fix for bug in Property task
Date Fri, 21 Jul 2000 19:16:47 GMT
Greetings -

I would like to see the following patch made... The error is glaring,
but not critical.

It allows Property to print out the *correct* property name when it
does not override it.

And speaking if immutable properties, doesn't this check belong in
Project.setProperty? I would be happy to put it there.

- Paul Philion

Index: src/main/org/apache/tools/ant/taskdefs/Property.java
===================================================================
RCS file:
/home/cvspublic/jakarta-ant/src/main/org/apache/tools/ant/taskdefs/Pro
perty.java,v
retrieving revision 1.9
diff -u -r1.9 Property.java
--- src/main/org/apache/tools/ant/taskdefs/Property.java
2000/07/21 14:24:35    1.9
+++ src/main/org/apache/tools/ant/taskdefs/Property.java
2000/07/21 19:10:18
@@ -171,13 +171,13 @@
             if (project.getUserProperty(n) == null) {
                 project.setUserProperty(n, v);
             } else {
-                log("Override ignored for " + name,
Project.MSG_VERBOSE);
+                log("Override ignored for " + n,
Project.MSG_VERBOSE);
             }
         } else {
             if (project.getProperty(n) == null) {
                 project.setProperty(n, v);
             } else {
-                log("Override ignored for " + name,
Project.MSG_VERBOSE);
+                log("Override ignored for " + n,
Project.MSG_VERBOSE);
             }
         }
     }



Mime
View raw message