ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From (Patrick Chanezon)
Subject Re: Javadoc patch
Date Thu, 29 Jun 2000 17:57:04 GMT
Hi Conor,
thanks for commiting that patch, my project will now be able to update to the
latest ant release.

As of distinguishing the attribute name of link and group from the nested
element name, I had no ideological opinion about it: it is just that in my
tests, it appeared that if they have the same name, an old build.xml file using
the attribute would not work anymore: you would get an exception.
And backward compatibility seems to me a very important requirement.

Did you test that scenario ?
If so I'm very happy with the solution.
If not I suggest you change the name of the nested elements.


Conor MacNeill wrote:

> I have applied Patrick's Javadoc patch with a few changes.
> I change the nested elements from
> <groups> to <group>
> <links> to <link>
> <linkofflines> to <link offline="yes">
> This seems a little clearer to me since each element only describes a single
> link or group. I know Patrick wanted to distinguish the nested element from
> the attribute but I think it is still clear. Combining the two link types
> into a single element seemed logical and makes it easy to change from the
> offline form to the online form.
> I also added support for multiple source paths. To do this I added my
> PathTokenizer object which I have previously discussed.
> Let me know if there are any issues.
> Conor

Patrick Chanezon, iPlanet Market Maker- Portal/EServices Technical Lead
Netscape Communications Corp. -
Opinions are my own.

"Two monks were arguing about a flag. One said: `The flag is moving.'
The other said: `The wind is moving.'
The sixth patriach happened to be passing by. He told them: `Not the wind, not
the flag; mind is moving.'"
Zen Koan

View raw message