ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Conor MacNeill" <co...@m64.com>
Subject RE: Javadoc patch
Date Fri, 30 Jun 2000 11:34:32 GMT
Stefan,

> >>>>> "CM" == Conor MacNeill <conor@m64.com> writes:
>
>  CM> I also added support for multiple source paths. To do this I
>  CM> added my PathTokenizer object which I have previously discussed.
>
>  CM> Let me know if there are any issues.
>
> Sorry, Connor, must have missed that discussion. Two issues:
>

Thomas and I discussed it a little in the context of his Path proposal. It
can probably go away in the future ... when that stuff is available.


> (1) is there any reason to make tokenizer and lookahead package
> private instead of private?

No - an oversight on my part.

>
> (2) I feel returning the lookahead String in nextToken instead of
> scanning for a DOS path could be wrong in very strange cases (take
> c:d:\path for example, this would return c, d, \path). I could be
> wrong but maybe make it something like
>

Yes, you are right and I have made the change.


> Stefan
>


Mime
View raw message