Return-Path: <james.davidson@eng.sun.com>
Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm
Delivered-To: mailing list ant-dev@jakarta.apache.org
Received: (qmail 1425 invoked from network); 21 Apr 2000 15:59:12 -0000
Received: from mercury.sun.com (192.9.25.1)
  by locus.apache.org with SMTP; 21 Apr 2000 15:59:12 -0000
Received: from shorter.eng.sun.com ([129.144.174.35])
	by mercury.Sun.COM (8.9.3+Sun/8.9.3) with ESMTP id IAA18540
	for <ant-dev@jakarta.apache.org>; Fri, 21 Apr 2000 08:59:11 -0700 (PDT)
Received: from eng.sun.com (pra-rem-8.Czech.Sun.COM [129.156.75.109])
	by shorter.eng.sun.com (8.9.3+Sun/8.9.3/ENSMAIL,v1.7) with ESMTP id IAA06517
	for <ant-dev@jakarta.apache.org>; Fri, 21 Apr 2000 08:59:07 -0700 (PDT)
Message-ID: <39006C0A.FA7F4D6@eng.sun.com>
Date: Fri, 21 Apr 2000 07:56:10 -0700
From: James Duncan Davidson <james.davidson@eng.sun.com>
X-Mailer: Mozilla 4.72 [en] (Windows NT 5.0; I)
X-Accept-Language: en
MIME-Version: 1.0
To: ant-dev@jakarta.apache.org
Subject: Re: Ant Principles
References: 
 <E1B81A5627BAD01191B500805FC16B0E77AB4F@nlnwx001.nwgbak.nl.origin-it.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N


> I thought there was some consensus that attributes were tried
> to be casted intelligently, so setXxxx should be:
> 
>    void setXxxx(<ObjectType> value);      // attributes
> 
> where the String value of the attribute is tried to be casted
> to <ObjectType> (by using a constructor accepting a String, etc).
> Note that <ObjectType> in the setXxxx case might be a primitive
> type.

Yes.

> I also prefer the "addText(String value)" method over the
> "setText(String value)" because of the separate text chunks. It's
> up to the task to decide whether it wants it as a whole (just
> use StringBuffer.append() in addText) or as separate chunks.

Yes. I'm convinced.. :)