annotator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertknight <...@git.apache.org>
Subject [GitHub] incubator-annotator pull request #3: Prettier
Date Tue, 09 May 2017 16:30:30 GMT
Github user robertknight commented on a diff in the pull request:

    https://github.com/apache/incubator-annotator/pull/3#discussion_r115536537
  
    --- Diff: scripts/serve.js ---
    @@ -39,19 +39,16 @@ const packages = fs.readdirSync(packagesPath);
     
     const app = express();
     
    -packages.forEach((name) => {
    +packages.forEach(name => {
       const root = path.join(packagesPath, name);
       const entry = path.join(root, 'index.js');
       const dest = path.join(root, `${name}.bundle.js`);
    -  const external = (id) => /^@(annotator|hot)/.test(id);
    +  const external = id => /^@(annotator|hot)/.test(id);
    --- End diff --
    
    This is how prettier formats arrow functions with a single argument. There is [no option](https://github.com/prettier/prettier#options)
to change this.
    
    By design, prettier provides only a handful of options to choose major style options such
as single vs. double quotes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message