From issues-return-66876-archive-asf-public=cust-asf.ponee.io@ambari.apache.org Fri Feb 16 14:13:12 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6E25618077F for ; Fri, 16 Feb 2018 14:13:11 +0100 (CET) Received: (qmail 82755 invoked by uid 500); 16 Feb 2018 13:13:10 -0000 Mailing-List: contact issues-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list issues@ambari.apache.org Received: (qmail 82742 invoked by uid 99); 16 Feb 2018 13:13:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Feb 2018 13:13:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id CEE00C03CD for ; Fri, 16 Feb 2018 13:13:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id BdkyKVcxrsAD for ; Fri, 16 Feb 2018 13:13:09 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C76BC5FC52 for ; Fri, 16 Feb 2018 13:13:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4370AE043C for ; Fri, 16 Feb 2018 13:13:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id EC5E422556 for ; Fri, 16 Feb 2018 13:13:01 +0000 (UTC) Date: Fri, 16 Feb 2018 13:13:01 +0000 (UTC) From: "Hudson (JIRA)" To: issues@ambari.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AMBARI-20589) Ambari Admin Web: optimize string constants definition MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AMBARI-20589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366978#comment-16366978 ] Hudson commented on AMBARI-20589: --------------------------------- FAILURE: Integrated in Jenkins build Ambari-trunk-Commit #8744 (See [https://builds.apache.org/job/Ambari-trunk-Commit/8744/]) AMBARI-20589 Ambari Admin Web: optimize string constants definition. (aonishuk: [https://gitbox.apache.org/repos/asf?p=ambari.git&a=commit&h=b1c885221f85831f3ac7bd386550836e6d16f2af]) * (edit) ambari-admin/src/main/resources/ui/admin-web/app/views/clusters/manageAccess.html * (edit) ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/remoteClusterPage.html * (edit) ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/authentication/AuthenticationMainCtrl.js * (edit) ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js * (edit) ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/list.html * (edit) ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/PermissionsSaver.js * (edit) ambari-admin/src/main/resources/ui/admin-web/app/views/groups/create.html * (edit) ambari-admin/src/main/resources/ui/admin-web/app/views/loginActivities/loginMessage.html * (edit) ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsListCtrl.js * (edit) ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js * (edit) ambari-admin/src/main/resources/ui/admin-web/app/views/modals/AddVersionModal.html * (edit) ambari-admin/src/main/resources/ui/admin-web/app/scripts/directives/editableList.js * (edit) ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html * (edit) ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/remoteClusters/RemoteClustersListCtrl.js * (edit) ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/ExportBlueprintCtrl.js * (edit) ambari-admin/src/main/resources/ui/admin-web/app/views/modals/AddRepositoryModal.html * (edit) ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/loginActivities/LoginMessageMainCtrl.js * (edit) ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/list.html * (edit) ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/ClustersManageAccessCtrl.js * (edit) ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js * (edit) ambari-admin/src/main/resources/ui/admin-web/app/views/users/list.html * (edit) ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/AddVersionModal.js * (edit) ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/editRemoteClusterPage.html * (edit) ambari-admin/src/main/resources/ui/admin-web/app/views/authentication/main.html * (edit) ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/modals/create.html * (edit) ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersShowCtrl.js * (edit) ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html > Ambari Admin Web: optimize string constants definition > ------------------------------------------------------ > > Key: AMBARI-20589 > URL: https://issues.apache.org/jira/browse/AMBARI-20589 > Project: Ambari > Issue Type: Bug > Components: ambari-admin > Affects Versions: 3.0.0 > Reporter: Andrii Babiichuk > Assignee: Andrii Babiichuk > Priority: Major > Fix For: 3.0.0 > > Attachments: AMBARI-20589.patch > > > # Optimize string constants definition in admin-web so that they are easier searchable by key. > # Remove hardcoded strings from views and controllers in favor of constants where necessary. -- This message was sent by Atlassian JIRA (v7.6.3#76005)