ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-22763) Fix checkstyle failure after merging trunk to branch-3.0-perf
Date Thu, 11 Jan 2018 19:28:01 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-22763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322810#comment-16322810
] 

ASF GitHub Bot commented on AMBARI-22763:
-----------------------------------------

hapylestat commented on a change in pull request #86: [AMBARI-22763] Fix checkstyle failure
after merging trunk to branch-3.0-perf
URL: https://github.com/apache/ambari/pull/86#discussion_r161052030
 
 

 ##########
 File path: ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java
 ##########
 @@ -234,6 +234,13 @@ public void setPreInstalled(String isPreInstalled) {
       this.m_isPreInstalled = isPreInstalled.equalsIgnoreCase("true");
     }
 
+    public Boolean getPreInstalled() {
+      return m_isPreInstalled;
+    }
+
+    public boolean isScoped() {
 
 Review comment:
   why this getter is needed? it is not used anywhere and the only one role he have - be serialized
to json

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix checkstyle failure after merging trunk to branch-3.0-perf
> -------------------------------------------------------------
>
>                 Key: AMBARI-22763
>                 URL: https://issues.apache.org/jira/browse/AMBARI-22763
>             Project: Ambari
>          Issue Type: Task
>          Components: ambari-server
>    Affects Versions: 3.0.0
>            Reporter: Myroslav Papirkovskyi
>            Assignee: Myroslav Papirkovskyi
>             Fix For: 3.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message