Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B280A200D2B for ; Thu, 2 Nov 2017 17:48:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B0FEC160BE5; Thu, 2 Nov 2017 16:48:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 01F431609EB for ; Thu, 2 Nov 2017 17:48:04 +0100 (CET) Received: (qmail 67021 invoked by uid 500); 2 Nov 2017 16:48:04 -0000 Mailing-List: contact issues-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list issues@ambari.apache.org Received: (qmail 67012 invoked by uid 99); 2 Nov 2017 16:48:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Nov 2017 16:48:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 4EAD41A028E for ; Thu, 2 Nov 2017 16:48:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id mc31WQrypyJK for ; Thu, 2 Nov 2017 16:48:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 36AE260EF8 for ; Thu, 2 Nov 2017 16:48:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 74BE7E0D5C for ; Thu, 2 Nov 2017 16:48:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 307972414B for ; Thu, 2 Nov 2017 16:48:00 +0000 (UTC) Date: Thu, 2 Nov 2017 16:48:00 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@ambari.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AMBARI-22353) Remove properties.json And Switch To Adding Properties to ResourceProviders Dynamically MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 02 Nov 2017 16:48:05 -0000 [ https://issues.apache.org/jira/browse/AMBARI-22353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236098#comment-16236098 ] Hadoop QA commented on AMBARI-22353: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12895427/AMBARI-22353.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 45 new or modified test files. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in ambari-server: org.apache.ambari.server.api.query.render.MinimalRendererTest org.apache.ambari.server.api.TestSuite org.apache.ambari.server.controller.internal.RequestImplTest org.apache.ambari.server.controller.internal.RequestResourceProviderTest org.apache.ambari.server.controller.internal.AbstractResourceProviderTest org.apache.ambari.server.controller.internal.HostComponentResourceProviderTest org.apache.ambari.server.controller.internal.TargetClusterResourceProviderTest org.apache.ambari.server.controller.internal.JobResourceProviderTest org.apache.ambari.server.controller.internal.TaskAttemptResourceProviderTest org.apache.ambari.server.controller.internal.FeedResourceProviderTest org.apache.ambari.server.controller.internal.InstanceResourceProviderTest org.apache.ambari.server.controller.internal.WorkflowResourceProviderTest org.apache.ambari.server.api.query.QueryImplTest Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/12601//console This message is automatically generated. > Remove properties.json And Switch To Adding Properties to ResourceProviders Dynamically > --------------------------------------------------------------------------------------- > > Key: AMBARI-22353 > URL: https://issues.apache.org/jira/browse/AMBARI-22353 > Project: Ambari > Issue Type: Task > Components: ambari-server > Affects Versions: 3.0.0 > Reporter: Dmitry Lysnichenko > Assignee: Dmitry Lysnichenko > Priority: Major > Fix For: 3.0.0 > > Attachments: AMBARI-22353.patch > > > Legacy/ancient ResourceProviders use the {{properties.json}} file to govern which properties can be used with the provider. This seems like excessive decoupling without any benefit and usually leads to runtime errors when new or removed properties are forgotten. > This file should be removed and the providers should be registering the known properties on their own. -- This message was sent by Atlassian JIRA (v6.4.14#64029)