ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-22465) Post-Upgrade Tasks Use the Wrong Repository and Hooks Folders
Date Tue, 28 Nov 2017 18:02:00 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-22465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16269163#comment-16269163
] 

Hudson commented on AMBARI-22465:
---------------------------------

FAILURE: Integrated in Jenkins build Ambari-trunk-Commit #8455 (See [https://builds.apache.org/job/Ambari-trunk-Commit/8455/])
AMBARI-22465 Post-Upgrade Tasks Use the Wrong Repository and Hooks (hapylestat: [http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=82af6fb6d3f11476df203d9871cc978091891cfe])
* (edit) ambari-server/src/test/python/custom_actions/test_ru_execute_tasks.py
* (edit) ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py
* (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java


> Post-Upgrade Tasks Use the Wrong Repository and Hooks Folders
> -------------------------------------------------------------
>
>                 Key: AMBARI-22465
>                 URL: https://issues.apache.org/jira/browse/AMBARI-22465
>             Project: Ambari
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Jonathan Hurley
>            Assignee: Dmytro Grinenko
>            Priority: Critical
>             Fix For: 2.6.1
>
>         Attachments: AMBARI-22465.patch
>
>
> During an express upgrade, when performing an upgrade between stack versions, the wrong
repository/stacks/hooks are sent down during the {{post-upgrade}} step:
> {code}
>       <component name="FOO">
>         <pre-upgrade>
>           <task xsi:type="execute" hosts="all">
>             <script>scripts/upgrade.py</script>
>             <function>bar</function>
>           </task>
>         </pre-upgrade>
>         <upgrade>
>           <task xsi:type="restart-task"/>
>         </upgrade>
>         <post-upgrade>
>           <task xsi:type="execute" hosts="any">
>             <script>scripts/upgrade.py</script>
>             <function>baz</function>
>           </task>
>         </post-upgrade>
> {code}
> In both the {{pre-upgrade}} and {{post-upgrade}} commands, the scripts folder location
refers to the old stack. The restart/start command, however, is correct.
> It appears as though the problem is found here:
> https://github.com/apache/ambari/blob/branch-2.6/ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java#L1052-L1055
> {code:title=makeActionStage()}
>     // the ru_execute_tasks invokes scripts - it needs information about where
>     // the scripts live and for that it should always use the target repository
>     // stack
>     applyRepositoryAssociatedParameters(wrapper, effectiveRepositoryVersion.getStackId(),
params);
> {code}
> It uses the effective stack ID which during an express upgrade is the source stack of
the upgrade.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message