ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-22110) Some ResourceProviders Are Not Transactional
Date Mon, 02 Oct 2017 22:21:01 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-22110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188957#comment-16188957
] 

Hudson commented on AMBARI-22110:
---------------------------------

FAILURE: Integrated in Jenkins build Ambari-trunk-Commit #8189 (See [https://builds.apache.org/job/Ambari-trunk-Commit/8189/])
AMBARI-22110. Some ResourceProviders Are Not Transactional (ncole) (ncole: [http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=11163157134c5e805923a1677c1489783bff0419])
* (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java


> Some ResourceProviders Are Not Transactional
> --------------------------------------------
>
>                 Key: AMBARI-22110
>                 URL: https://issues.apache.org/jira/browse/AMBARI-22110
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>            Reporter: Nate Cole
>            Assignee: Nate Cole
>            Priority: Critical
>             Fix For: 2.6.0
>
>         Attachments: AMBARI-22110.patch
>
>
> While investigating an issue with VDFs which don't contain any OS's which match the cluster,
it was observed that, even after throwing an Exception inside of a Transaction, the entities
created inside that transaction were being committed. 
> Eventual investigation led to a problem between Guice/AOP and our ResourceProviders.
The Guice documentations says that {{@Transactional}} methods can only be intercepted on objects
created by Guice:
> https://github.com/google/guice/wiki/AOP:
> {quote}
> Instances must be created by Guice by an @Inject-annotated or no-argument constructor
It is not possible to use method interception on instances that aren't constructed by Guice.
> {quote}
> However, some of the ResourceProviders which use {{@Transactional}} are not constructed
by Guice.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message