Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F419F200D06 for ; Mon, 25 Sep 2017 09:10:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id ECCD71609E9; Mon, 25 Sep 2017 07:10:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 480071609BB for ; Mon, 25 Sep 2017 09:10:07 +0200 (CEST) Received: (qmail 62510 invoked by uid 500); 25 Sep 2017 07:10:03 -0000 Mailing-List: contact issues-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list issues@ambari.apache.org Received: (qmail 62434 invoked by uid 99); 25 Sep 2017 07:10:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Sep 2017 07:10:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 2C78BDB75A for ; Mon, 25 Sep 2017 07:10:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id hl4PaFqXcLZf for ; Mon, 25 Sep 2017 07:10:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 01C595FBDF for ; Mon, 25 Sep 2017 07:10:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8EFBBE0B20 for ; Mon, 25 Sep 2017 07:10:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 538AE24219 for ; Mon, 25 Sep 2017 07:10:00 +0000 (UTC) Date: Mon, 25 Sep 2017 07:10:00 +0000 (UTC) From: "Doroszlai, Attila (JIRA)" To: issues@ambari.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Reopened] (AMBARI-22040) configs.py does not work properly when dealing with files MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 25 Sep 2017 07:10:08 -0000 [ https://issues.apache.org/jira/browse/AMBARI-22040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doroszlai, Attila reopened AMBARI-22040: ---------------------------------------- Hi [~aonishuk], a bunch of python unit tests are failing due to changes in configs.py. Can you please check? {noformat:title=https://builds.apache.org/job/Ambari-trunk-Commit/8128/consoleText} ERROR: test_delete_config (TestConfigs.TestConfigs) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-common/src/test/python/mock/mock.py", line 1199, in patched return func(*args, **keywargs) File "/home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-server/src/test/python/TestConfigs.py", line 163, in test_delete_config configs.main() File "/home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-server/src/test/python/../../main/resources/scripts/configs.py", line 327, in main parser.error("One of required options is not passed") File "/usr/lib/python2.7/optparse.py", line 1584, in error self.exit(2, "%s: error: %s\n" % (self.get_prog_name(), msg)) File "/usr/lib/python2.7/optparse.py", line 1574, in exit sys.exit(status) SystemExit: 2 {noformat} > configs.py does not work properly when dealing with files > --------------------------------------------------------- > > Key: AMBARI-22040 > URL: https://issues.apache.org/jira/browse/AMBARI-22040 > Project: Ambari > Issue Type: Bug > Reporter: Andrew Onischuk > Assignee: Andrew Onischuk > Fix For: 2.6.0 > > Attachments: AMBARI-22040.patch > > > configs.py is used by users and support folks for modifying > configurations. While this works well for getting and setting individual > properties, it does not work well for dealing with json files. This is needed > for edits to *env.sh or stack_features. > _Current behavior_: > * Exporting ams-grafana-env does not give a properly formatted json file > * Cannot use a get change the json and set it back. > The expected behavior is to let the user modify the json file and re-import it > into the cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)