Mailing-List: contact issues-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Date: Wed, 6 Sep 2017 21:50:02 +0000 (UTC)
From: "Jayush Luniya (JIRA)" <jira@apache.org>
To: issues@ambari.apache.org
Message-ID: <JIRA.13100289.1504729678000.43699.1504734602586@Atlassian.JIRA>
In-Reply-To: <JIRA.13100289.1504729678000@Atlassian.JIRA>
References: <JIRA.13100289.1504729678000@Atlassian.JIRA> <JIRA.13100289.1504729678216@jira-lw-us.apache.org>
Subject: [jira] [Commented] (AMBARI-21897) Fix NPE in InstallHostTask
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 06 Sep 2017 21:50:09 -0000


    [ https://issues.apache.org/jira/browse/AMBARI-21897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156081#comment-16156081 ] 

Jayush Luniya commented on AMBARI-21897:
----------------------------------------

This can also occur in 2.6 if there are no client components on a host. 

> Fix NPE in InstallHostTask
> --------------------------
>
>                 Key: AMBARI-21897
>                 URL: https://issues.apache.org/jira/browse/AMBARI-21897
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>    Affects Versions: 2.6.0
>            Reporter: Jayush Luniya
>            Assignee: Jayush Luniya
>            Priority: Blocker
>             Fix For: 2.6.0
>
>         Attachments: AMBARI-21897.patch
>
>
> {code}
> Exception in thread "pool-4-thread-1" java.lang.NullPointerException
>         at org.apache.ambari.server.topology.tasks.InstallHostTask.runTask(InstallHostTask.java:54)
>         at org.apache.ambari.server.topology.tasks.TopologyHostTask.run(TopologyHostTask.java:51)
>         at org.apache.ambari.server.topology.HostOfferResponse$1.run(HostOfferResponse.java:83)
>         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>         at java.lang.Thread.run(Thread.java:745)
> {code}
> This seems to be because response can be null if stages is null and we don't have a check for it. 
> {code}
>     RequestStatusResponse response = clusterTopology.installHost(hostRequest.getHostName(), skipInstallTaskCreate, skipFailure);
>       List<ShortTaskStatus> underlyingTasks = response.getTasks();
> {code}
> {code}
> /**
>  * Build a request status response.
>  *
>  * @return a {@link org.apache.ambari.server.controller.RequestStatusResponse} for the request
>  */
> public RequestStatusResponse getRequestStatusResponse() {
>   RequestStatusResponse response = null;
>   if (! stages.isEmpty()) {
>     response = new RequestStatusResponse(id);
>     List<HostRoleCommand> hostRoleCommands =
>         actionManager.getRequestTasks(id);
>     response.setRequestContext(actionManager.getRequestContext(id));
>     List<ShortTaskStatus> tasks = new ArrayList<>();
>     for (HostRoleCommand hostRoleCommand : hostRoleCommands) {
>       tasks.add(new ShortTaskStatus(hostRoleCommand));
>     }
>     response.setTasks(tasks);
>   }
>   return response;
> }
> {code}


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)