ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitry Lysnichenko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-21744) package_regex in get_package_from_available() can match wrong pkg
Date Fri, 18 Aug 2017 15:18:00 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-21744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133116#comment-16133116
] 

Dmitry Lysnichenko commented on AMBARI-21744:
---------------------------------------------

Reverted for now because it covers not all cases
To https://git-wip-us.apache.org/repos/asf/ambari.git
   2f4fe911b8..5d0914c3a0  branch-2.6 -> branch-2.6
   5f6ce4ea53..ca8ae51afe  trunk -> trunk


> package_regex in get_package_from_available() can match wrong pkg
> -----------------------------------------------------------------
>
>                 Key: AMBARI-21744
>                 URL: https://issues.apache.org/jira/browse/AMBARI-21744
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>            Reporter: Dmitry Lysnichenko
>            Assignee: Dmitry Lysnichenko
>            Priority: Critical
>             Fix For: 2.6.0
>
>         Attachments: AMBARI-21744.patch
>
>
> Due to the issue with regex (missing ^ and $ boundaries), resource_management.libraries.script.script.Script#get_package_from_available
may return wrong package.
> {code}
> >>> list=['hbase_3_0_0_0_229-master', 'hbase_3_0_0_0_229']
> >>> if re.match('hbase_(\d|_)+', 'hbase_3_0_0_0_229-master'):
> ...    print 'YES'
> ...
> YES
> >>> if re.match('hbase_(\d|_)+', 'hbase_3_0_0_0_229'):
> ...    print 'YES'
> ...
> YES
> {code}
> In this case, the first package name from a list of available packages will be returned.
> The impact of bug is that we may install a wrong package if it's simillary named and
goes first at list. Patch is a single-line fix.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message