ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-21744) package_regex in get_package_from_available() can match wrong pkg
Date Wed, 30 Aug 2017 11:41:00 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-21744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147102#comment-16147102
] 

Hudson commented on AMBARI-21744:
---------------------------------

FAILURE: Integrated in Jenkins build Ambari-trunk-Commit #7964 (See [https://builds.apache.org/job/Ambari-trunk-Commit/7964/])
AMBARI-21744. package_regex in get_package_from_available() can match (dlysnichenko: [http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=5e399daeb36615a3434785ebe8afefd2e506f41f])
* (edit) ambari-common/src/main/python/resource_management/libraries/script/script.py
* (edit) ambari-server/src/test/python/custom_actions/TestInstallPackages.py


> package_regex in get_package_from_available() can match wrong pkg
> -----------------------------------------------------------------
>
>                 Key: AMBARI-21744
>                 URL: https://issues.apache.org/jira/browse/AMBARI-21744
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>    Affects Versions: 2.5.2
>            Reporter: Dmitry Lysnichenko
>            Assignee: Dmitry Lysnichenko
>            Priority: Critical
>             Fix For: 2.6.0
>
>         Attachments: AMBARI-21744.patch
>
>
> Due to the issue with regex (missing ^ and $ boundaries), resource_management.libraries.script.script.Script#get_package_from_available
may return wrong package.
> {code}
> >>> list=['hbase_3_0_0_0_229-master', 'hbase_3_0_0_0_229']
> >>> if re.match('hbase_(\d|_)+', 'hbase_3_0_0_0_229-master'):
> ...    print 'YES'
> ...
> YES
> >>> if re.match('hbase_(\d|_)+', 'hbase_3_0_0_0_229'):
> ...    print 'YES'
> ...
> YES
> {code}
> In this case, the first package name from a list of available packages will be returned.
> The impact of bug is that we may install a wrong package if it's simillary named and
goes first at list. Patch is a single-line fix.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message