ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-21365) Accidental globals in JavaScript code
Date Wed, 05 Jul 2017 18:38:03 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-21365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075215#comment-16075215
] 

Hadoop QA commented on AMBARI-21365:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12874872/AMBARI-21365.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in ambari-logsearch/ambari-logsearch-web
ambari-web contrib/views/capacity-scheduler.

Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/11707//console

This message is automatically generated.

> Accidental globals in JavaScript code
> -------------------------------------
>
>                 Key: AMBARI-21365
>                 URL: https://issues.apache.org/jira/browse/AMBARI-21365
>             Project: Ambari
>          Issue Type: Improvement
>          Components: contrib
>    Affects Versions: trnk
>            Reporter: Max Schaefer
>            Priority: Minor
>         Attachments: AMBARI-21365.patch
>
>
> As detected by [lgtm|https://lgtm.com], a few JavaScript variables are used like local
variables but are missing declarations, meaning that they become globals by default. This
seems unlikely to be intentional, and is fixed by the attached patch.
> For more details see https://lgtm.com/projects/g/apache/ambari/alerts. (Full disclosure:
I work on the JavaScript analysis behind lgtm.)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message