Mailing-List: contact issues-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Date: Mon, 19 Jun 2017 09:11:00 +0000 (UTC)
From: "Dmytro Sen (JIRA)" <jira@apache.org>
To: issues@ambari.apache.org
Message-ID: <JIRA.13079825.1497461185000.46038.1497863460497@Atlassian.JIRA>
In-Reply-To: <JIRA.13079825.1497461185000@Atlassian.JIRA>
References: <JIRA.13079825.1497461185000@Atlassian.JIRA> <JIRA.13079825.1497461185666@jira-lw-us.apache.org>
Subject: [jira] [Updated] (AMBARI-21248) Exception needs to be handled
 properly for mail alert
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Mon, 19 Jun 2017 09:11:07 -0000


     [ https://issues.apache.org/jira/browse/AMBARI-21248?page=3Dcom.atlass=
ian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dmytro Sen updated AMBARI-21248:
--------------------------------
    Attachment: AMBARI-21248_4.patch

> Exception needs to be handled properly for mail alert
> -----------------------------------------------------
>
>                 Key: AMBARI-21248
>                 URL: https://issues.apache.org/jira/browse/AMBARI-21248
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>    Affects Versions: 2.4.2
>            Reporter: Richard Zang
>            Assignee: Dmytro Sen
>            Priority: Critical
>             Fix For: 2.5.2
>
>         Attachments: AMBARI-21248_4.patch
>
>
> In org.apache.ambari.server.state.services.AlertNoticeDispatchService, we=
 have below code snippet:
> {code}
> ...=20
> protected void runOneIteration() throws Exception {=20
> =E2=80=A6=20
> String targetType =3D target.getNotificationType();=20
> NotificationDispatcher dispatcher =3D m_dispatchFactory.getDispatcher(tar=
getType);=20
> =E2=80=A6=20
> if (dispatcher.isDigestSupported()) {=20
> ...
> {code}
> If the database has a change to AlertTargetEntity's targetType column (un=
likely but let's assume it happened), then dispatcher can be null and the s=
ubsequent if clause will throw an exception. In https://github.com/google/g=
uava/blob/master/guava/src/com/google/common/util/concurrent/AbstractSchedu=
ledService.java, we see that the exception may happen silently since shutDo=
wn() and notifyFailed() does not log anything.=20
> ...=20
> {code}
> class Task implements Runnable {
>     @Override
>     public void run() {
>         lock.lock();
>         try {
>             if (runningTask.isCancelled()) { // task may have been cancel=
led while blocked on the lock. return; }
>                 AbstractScheduledService.this.runOneIteration();
>             } catch (Throwable t) {
>                 try {
>                     shutDown();
>                 } catch (Exception ignored) {
>                     logger.log(Level.WARNING, "Error while attempting to =
shut down the service after failure.", ignored);
>                 }
>                 notifyFailed(t);
>                 runningTask.cancel(false); // prevent future invocations.=
=20
>             } finally {
>                 lock.unlock();
>             }
>         }
>     }
> }
> {code}
> So, runOneIteration will shutdown the scheduler if it hits an uncaught ex=
ception. We should wrap a try/catch.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)