ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-19149) Clean up Ambari Server source code warnings
Date Thu, 25 May 2017 09:13:04 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-19149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024436#comment-16024436
] 

Hudson commented on AMBARI-19149:
---------------------------------

FAILURE: Integrated in Jenkins build Ambari-trunk-Commit #7535 (See [https://builds.apache.org/job/Ambari-trunk-Commit/7535/])
AMBARI-19149. Code cleanup: identical catch blocks (adoroszlai: [http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=1adb70d53041e64ac7e844592453cd3085704105])
* (edit) ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/IPAKerberosOperationHandler.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/ScriptRunner.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ServiceComponentHostEventWrapper.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/security/encryption/MasterKeyServiceImpl.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/api/handlers/UpdateHandler.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/security/encryption/AESEncryptor.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/agent/LocalAgentSimulator.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRenderer.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/utils/HTTPUtils.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java


> Clean up Ambari Server source code warnings
> -------------------------------------------
>
>                 Key: AMBARI-19149
>                 URL: https://issues.apache.org/jira/browse/AMBARI-19149
>             Project: Ambari
>          Issue Type: Task
>          Components: ambari-server
>            Reporter: Doroszlai, Attila
>            Assignee: Doroszlai, Attila
>             Fix For: 3.0.0
>
>         Attachments: AMBARI-19149-10.patch, AMBARI-19149-11.patch, AMBARI-19149-12.patch,
AMBARI-19149-13.patch, AMBARI-19149-1.patch, AMBARI-19149-3.patch, AMBARI-19149-4.patch, AMBARI-19149-5.patch,
AMBARI-19149-6.patch, AMBARI-19149-7.patch, AMBARI-19149-9.patch, IDEA_Ambari_v1.xml
>
>
> Eclipse's default warnings generated for {{ambari-server}} number roughly over 3300.
Out of these, at least half of them are:
> * Unused imports
> * Type safety due to forgotten {{<>}}
> * Missing Serialization IDs from anonymous {{HashMap}} implementations
> * Unused variables
> * {{Capture<T>}} in tests
> * {{switch}} fall-through and missing {{case statements}}: *only makes changes which
won't affect existing functionality*
> This makes spotting actual problems, like missing {{case}} statements a nightmare. We
need to go through and clean out as many of these warnings as possible. 
> Note: With respect to the import cleanup, the IDE of choice should have the following
import order setup. They should always be expanded and never use {{*}}.
> # {{java}}
> # {{javax}}
> # {{org}}
> # {{com}}
> # other



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message