ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yusaku Sako (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (AMBARI-20878) Running "mvn package" on ambari-web should not update the yarn.lock file
Date Thu, 27 Apr 2017 19:19:04 GMT

     [ https://issues.apache.org/jira/browse/AMBARI-20878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Yusaku Sako updated AMBARI-20878:
---------------------------------
    Status: Patch Available  (was: Open)

> Running "mvn package" on ambari-web should not update the yarn.lock file
> ------------------------------------------------------------------------
>
>                 Key: AMBARI-20878
>                 URL: https://issues.apache.org/jira/browse/AMBARI-20878
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-web
>    Affects Versions: 2.5.1
>            Reporter: Yusaku Sako
>            Assignee: Yusaku Sako
>            Priority: Critical
>             Fix For: 2.5.1
>
>         Attachments: AMBARI-20878.patch
>
>
> Currently, when "mvn package" is run, yarn package manager *in some cases* updates the
yarn.lock file.  In theory, yarn.lock file should not change unless package.json is changed.
 However, it seems that this behavior is not guaranteed in some cases.  This is a pain since
yarn.lock is checked into git so whenever yarn.lock is updated, it is treated as uncommitted
changes.
> In Yarn package manager, there's an option called "--pure-lockfile" that prevents unexpected
behavior from happening (there are some long discussions about why this behavior is not by
default in the first place: https://github.com/yarnpkg/yarn/issues/570).
> For mvn based builds, we can simply use that option.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message