ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-20823) Remove user input from invalid renderer error message
Date Tue, 25 Apr 2017 22:12:04 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983709#comment-15983709
] 

Hudson commented on AMBARI-20823:
---------------------------------

SUCCESS: Integrated in Jenkins build Ambari-trunk-Commit #7354 (See [https://builds.apache.org/job/Ambari-trunk-Commit/7354/])
AMBARI-20823. Remove user input from invalid renderer error message (adoroszlai: [http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=ec51e16630debc6595d92a29690ce62fd719e2ca])
* (edit) ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseResourceDefinitionTest.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseResourceDefinition.java


> Remove user input from invalid renderer error message
> -----------------------------------------------------
>
>                 Key: AMBARI-20823
>                 URL: https://issues.apache.org/jira/browse/AMBARI-20823
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>    Affects Versions: 1.5.0
>            Reporter: Robert Levas
>            Assignee: Attila Magyar
>            Priority: Critical
>             Fix For: 2.5.1
>
>         Attachments: AMBARI-20823.patch
>
>
> Remove user input from invalid renderer error message to avoid potential XSS attacks.

> The user input data returned in the exception thrown at
> {code:title=org/apache/ambari/server/api/resources/BaseResourceDefinition.java:135}
>       throw new IllegalArgumentException("Invalid renderer name: " + name +
>           " for resource of type: " + m_type);
> {code}
> should be removed and the error message changed to:
> {noformat}
> Invalid renderer name for resource of type <resource type>.m
> {noformat}
> or simply
> {noformat}
> Invalid renderer name.
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message