ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-20697) Stack advisor code in 2.3 refactor logic for ranger Kafka Plugin
Date Fri, 07 Apr 2017 00:56:41 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960102#comment-15960102
] 

Hadoop QA commented on AMBARI-20697:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12862377/AMBARI-20697.PATCH
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 core tests{color}.  The test build failed in ambari-server 

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/11327//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/11327//console

This message is automatically generated.

> Stack advisor code in 2.3 refactor logic for ranger Kafka Plugin
> ----------------------------------------------------------------
>
>                 Key: AMBARI-20697
>                 URL: https://issues.apache.org/jira/browse/AMBARI-20697
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>              Labels: stack, stackadvisor
>         Attachments: AMBARI-20697.PATCH
>
>
>  if ranger_plugin_enabled:
>       # If ranger-kafka-plugin-properties/ranger-kafka-plugin-enabled,
>       # determine if the Ranger/Kafka plug-in enabled enabled or not
>       if 'ranger-kafka-plugin-properties' in configurations and \
>           'ranger-kafka-plugin-enabled' in configurations['ranger-kafka-plugin-properties']['properties']:
>         ranger_plugin_enabled = configurations['ranger-kafka-plugin-properties']['properties']['ranger-kafka-plugin-enabled'].lower()
== 'yes'
>       # If ranger-kafka-plugin-properties/ranger-kafka-plugin-enabled was not changed,
>       # determine if the Ranger/Kafka plug-in enabled enabled or not
>       elif 'ranger-kafka-plugin-properties' in services['configurations'] and \
>           'ranger-kafka-plugin-enabled' in services['configurations']['ranger-kafka-plugin-properties']['properties']:
>         ranger_plugin_enabled = services['configurations']['ranger-kafka-plugin-properties']['properties']['ranger-kafka-plugin-enabled'].lower()
== 'yes'
>     # Determine the value for kafka-broker/authorizer.class.name
>     if ranger_plugin_enabled:
>       # If the Ranger plugin for Kafka is enabled, set authorizer.class.name to
>       # "org.apache.ranger.authorization.kafka.authorizer.RangerKafkaAuthorizer" whether
Kerberos is
>       # enabled or not.
>       putKafkaBrokerProperty("authorizer.class.name", 'org.apache.ranger.authorization.kafka.authorizer.RangerKafkaAuthorizer')
>     elif security_enabled:
>       putKafkaBrokerProperty("authorizer.class.name", 'kafka.security.auth.SimpleAclAuthorizer')
>     else:
>       putKafkaBrokerAttributes('authorizer.class.name', 'delete', 'true')
> In the above code after ranger_plugin_enabled is true and inside conditions don't match
then also we set authorizer.class.name to RangerKafakAuthorizer.  So, to avoid this after
checking ranger_plugin_enabled set to false and then continue with code checking



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message