Mailing-List: contact issues-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Date: Mon, 20 Mar 2017 12:04:41 +0000 (UTC)
From: "Andrew Onischuk (JIRA)" <jira@apache.org>
To: issues@ambari.apache.org
Message-ID: <JIRA.13050181.1489189784000.64633.1490011481617@Atlassian.JIRA>
In-Reply-To: <JIRA.13050181.1489189784000@Atlassian.JIRA>
References: <JIRA.13050181.1489189784000@Atlassian.JIRA> <JIRA.13050181.1489189784468@jira-lw-us.apache.org>
Subject: [jira] [Updated] (AMBARI-20404) Enhance error message for invalid
 chars in properties/values
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Mon, 20 Mar 2017 12:04:51 -0000


     [ https://issues.apache.org/jira/browse/AMBARI-20404?page=3Dcom.atlass=
ian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Onischuk updated AMBARI-20404:
-------------------------------------
    Fix Version/s: 3.0.0

> Enhance error message for invalid chars in properties/values
> ------------------------------------------------------------
>
>                 Key: AMBARI-20404
>                 URL: https://issues.apache.org/jira/browse/AMBARI-20404
>             Project: Ambari
>          Issue Type: Bug
>    Affects Versions: 2.5.0
>            Reporter: Yesha Vora
>            Assignee: Andrew Onischuk
>             Fix For: 3.0.0
>
>         Attachments: AMBARI-20404.patch
>
>
> Scenario:
> * Added below configs to spark2 default
> {code}
> spark.io.encryption.enabled =3D true
> spark.io.encryption.keySizeBits =3D 128
> spark.io.encryption.keygen.algorithm =3D HmacSHA1=E2=80=8B {code}
> * Restart affected services.=20
> Spark2-client is failing to restart with below error.
> {code:title=3Dstderr}
> Traceback (most recent call last):
>   File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/=
scripts/spark_client.py", line 60, in <module>
>     SparkClient().execute()
>   File "/usr/lib/python2.6/site-packages/resource_management/libraries/sc=
ript/script.py", line 313, in execute
>     method(env)
>   File "/usr/lib/python2.6/site-packages/resource_management/libraries/sc=
ript/script.py", line 721, in restart
>     self.install(env)
>   File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/=
scripts/spark_client.py", line 36, in install
>     self.configure(env)
>   File "/usr/lib/python2.6/site-packages/resource_management/libraries/sc=
ript/script.py", line 116, in locking_configure
>     original_configure(obj, *args, **kw)
>   File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/=
scripts/spark_client.py", line 42, in configure
>     setup_spark(env, 'client', upgrade_type=3Dupgrade_type, action =3D 'c=
onfig')
>   File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/=
scripts/setup_spark.py", line 56, in setup_spark
>     mode=3D0644
>   File "/usr/lib/python2.6/site-packages/resource_management/core/base.py=
", line 155, in __init__
>     self.env.run()
>   File "/usr/lib/python2.6/site-packages/resource_management/core/environ=
ment.py", line 160, in run
>     self.run_action(resource, action)
>   File "/usr/lib/python2.6/site-packages/resource_management/core/environ=
ment.py", line 124, in run_action
>     provider_action()
>   File "/usr/lib/python2.6/site-packages/resource_management/libraries/pr=
oviders/properties_file.py", line 54, in action_create
>     mode =3D self.resource.mode
>   File "/usr/lib/python2.6/site-packages/resource_management/core/base.py=
", line 155, in __init__
>     self.env.run()
>   File "/usr/lib/python2.6/site-packages/resource_management/core/environ=
ment.py", line 160, in run
>     self.run_action(resource, action)
>   File "/usr/lib/python2.6/site-packages/resource_management/core/environ=
ment.py", line 124, in run_action
>     provider_action()
>   File "/usr/lib/python2.6/site-packages/resource_management/core/provide=
rs/system.py", line 123, in action_create
>     content =3D self._get_content()
>   File "/usr/lib/python2.6/site-packages/resource_management/core/provide=
rs/system.py", line 160, in _get_content
>     return content()
>   File "/usr/lib/python2.6/site-packages/resource_management/core/source.=
py", line 52, in __call__
>     return self.get_content()
>   File "/usr/lib/python2.6/site-packages/resource_management/core/source.=
py", line 143, in get_content
>     rendered =3D self.template.render(self.context)
>   File "/usr/lib/python2.6/site-packages/ambari_jinja2/environment.py", l=
ine 891, in render
>     return self.environment.handle_exception(exc_info, True)
>   File "<template>", line 3, in top-level template code
> UnicodeEncodeError: 'ascii' codec can't encode character u'\u200b' in pos=
ition 8: ordinal not in range(128)
> {code}
> Here, While copy-pasting properties, <200b> was appended with HmacSHA1. I=
 believe the error message should be more clear and specific on which prope=
rty/value has unwanted chars.=20
> Can this validation move while saving configs ?=20


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)