ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Onischuk (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (AMBARI-20404) Enhance error message for invalid chars in properties/values
Date Mon, 20 Mar 2017 12:04:41 GMT

     [ https://issues.apache.org/jira/browse/AMBARI-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrew Onischuk updated AMBARI-20404:
-------------------------------------
    Fix Version/s: 3.0.0

> Enhance error message for invalid chars in properties/values
> ------------------------------------------------------------
>
>                 Key: AMBARI-20404
>                 URL: https://issues.apache.org/jira/browse/AMBARI-20404
>             Project: Ambari
>          Issue Type: Bug
>    Affects Versions: 2.5.0
>            Reporter: Yesha Vora
>            Assignee: Andrew Onischuk
>             Fix For: 3.0.0
>
>         Attachments: AMBARI-20404.patch
>
>
> Scenario:
> * Added below configs to spark2 default
> {code}
> spark.io.encryption.enabled = true
> spark.io.encryption.keySizeBits = 128
> spark.io.encryption.keygen.algorithm = HmacSHA1‚Äč {code}
> * Restart affected services. 
> Spark2-client is failing to restart with below error.
> {code:title=stderr}
> Traceback (most recent call last):
>   File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/spark_client.py",
line 60, in <module>
>     SparkClient().execute()
>   File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
line 313, in execute
>     method(env)
>   File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
line 721, in restart
>     self.install(env)
>   File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/spark_client.py",
line 36, in install
>     self.configure(env)
>   File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
line 116, in locking_configure
>     original_configure(obj, *args, **kw)
>   File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/spark_client.py",
line 42, in configure
>     setup_spark(env, 'client', upgrade_type=upgrade_type, action = 'config')
>   File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/setup_spark.py",
line 56, in setup_spark
>     mode=0644
>   File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 155,
in __init__
>     self.env.run()
>   File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line
160, in run
>     self.run_action(resource, action)
>   File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line
124, in run_action
>     provider_action()
>   File "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/properties_file.py",
line 54, in action_create
>     mode = self.resource.mode
>   File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 155,
in __init__
>     self.env.run()
>   File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line
160, in run
>     self.run_action(resource, action)
>   File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line
124, in run_action
>     provider_action()
>   File "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
line 123, in action_create
>     content = self._get_content()
>   File "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
line 160, in _get_content
>     return content()
>   File "/usr/lib/python2.6/site-packages/resource_management/core/source.py", line 52,
in __call__
>     return self.get_content()
>   File "/usr/lib/python2.6/site-packages/resource_management/core/source.py", line 143,
in get_content
>     rendered = self.template.render(self.context)
>   File "/usr/lib/python2.6/site-packages/ambari_jinja2/environment.py", line 891, in
render
>     return self.environment.handle_exception(exc_info, True)
>   File "<template>", line 3, in top-level template code
> UnicodeEncodeError: 'ascii' codec can't encode character u'\u200b' in position 8: ordinal
not in range(128)
> {code}
> Here, While copy-pasting properties, <200b> was appended with HmacSHA1. I believe
the error message should be more clear and specific on which property/value has unwanted chars.

> Can this validation move while saving configs ? 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message