ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-19944) Increase SNMP Unit Test Coverage
Date Sat, 11 Feb 2017 13:27:42 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-19944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862398#comment-15862398
] 

Hadoop QA commented on AMBARI-19944:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12852191/AMBARI-19944_3.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in ambari-server:

                  org.apache.ambari.server.checks.DatabaseConsistencyCheckHelperTest

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/10529//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/10529//console

This message is automatically generated.

> Increase SNMP Unit Test Coverage
> --------------------------------
>
>                 Key: AMBARI-19944
>                 URL: https://issues.apache.org/jira/browse/AMBARI-19944
>             Project: Ambari
>          Issue Type: Task
>          Components: alerts, test
>    Affects Versions: 2.5.0
>            Reporter: Dmytro Sen
>            Assignee: Dmytro Sen
>             Fix For: 2.5.0
>
>         Attachments: AMBARI-19944_3.patch, AMBARI-19944.patch
>
>
> The current unit tests for SNMP alert notifications do not provide enough of an end-to-end
coverage there should be. We should mock SNMP4J classes to ensure that the alert framework
is capable of completing an end-to-end dispatch of a trap. This includes:
> Instrumenting the SNMP4J dispatcher to intercept the SNMP message and validating the
OIDs stored
> Instrumenting Ambari alert code so that an AlertNotice is picked up and converted into
a delivered SNMP message.
> This unit test needs to cover test cases:
> 4 Verify AMBARI_SNMP trap is working fine when alerts are triggered (Need to confirm
whether covered in unit tests)
> 1 Setup a SNMP trap receiver server on one of the hosts
> 2 Create AMBARI_SNMP trap notification to use the receiver started in Step 1
> 3 Trigger an alert to be in CRIT status. E.g STOP MR to trigger HistoryServer Alert
> 4 Verify the traps are received by the receiver and verify the OID received is correct



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message