Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E0D63200C05 for ; Mon, 23 Jan 2017 14:09:48 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id DF71F160B49; Mon, 23 Jan 2017 13:09:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 33C40160B3E for ; Mon, 23 Jan 2017 14:09:48 +0100 (CET) Received: (qmail 46063 invoked by uid 500); 23 Jan 2017 13:09:47 -0000 Mailing-List: contact issues-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list issues@ambari.apache.org Received: (qmail 46054 invoked by uid 99); 23 Jan 2017 13:09:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Jan 2017 13:09:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id ACBA0C129E for ; Mon, 23 Jan 2017 13:09:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.199 X-Spam-Level: X-Spam-Status: No, score=-1.199 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id JJwpx_PvIuLN for ; Mon, 23 Jan 2017 13:09:45 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 743DF5F46D for ; Mon, 23 Jan 2017 13:09:45 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 52E9BE039B for ; Mon, 23 Jan 2017 13:09:27 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 955F125290 for ; Mon, 23 Jan 2017 13:09:26 +0000 (UTC) Date: Mon, 23 Jan 2017 13:09:26 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@ambari.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AMBARI-19672) Alert Popup doesn't execute callback if it's closed without click on "Primary" MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 23 Jan 2017 13:09:49 -0000 [ https://issues.apache.org/jira/browse/AMBARI-19672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834450#comment-15834450 ] Hadoop QA commented on AMBARI-19672: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12848887/AMBARI-19672.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in ambari-web. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/10197//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/10197//console This message is automatically generated. > Alert Popup doesn't execute callback if it's closed without click on "Primary" > ------------------------------------------------------------------------------ > > Key: AMBARI-19672 > URL: https://issues.apache.org/jira/browse/AMBARI-19672 > Project: Ambari > Issue Type: Bug > Components: ambari-web > Affects Versions: 2.5.0 > Reporter: Oleg Nechiporenko > Assignee: Oleg Nechiporenko > Priority: Critical > Fix For: 2.5.0 > > Attachments: AMBARI-19672.patch > > > {{App.showAlertPopup}} shows popup with some message in the its body and on button - "Primary". Click on it execute passed callback (if it exists). Clicking on "x" or "Esc"-press closes modal without callback execution. > Since this modal is not a confirmation-modal (we have {{App.showConfirmationPopup}}), any interaction with it (click "Ok", press "Esc", click "x") should execute passed callback. -- This message was sent by Atlassian JIRA (v6.3.4#6332)