Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A9C82200BFE for ; Mon, 16 Jan 2017 19:12:40 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id A858C160B41; Mon, 16 Jan 2017 18:12:40 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F0604160B28 for ; Mon, 16 Jan 2017 19:12:39 +0100 (CET) Received: (qmail 26448 invoked by uid 500); 16 Jan 2017 18:12:39 -0000 Mailing-List: contact issues-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list issues@ambari.apache.org Received: (qmail 26439 invoked by uid 99); 16 Jan 2017 18:12:39 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Jan 2017 18:12:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id A52D7180BB7 for ; Mon, 16 Jan 2017 18:12:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.199 X-Spam-Level: X-Spam-Status: No, score=-1.199 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id GzsXFNNXmDko for ; Mon, 16 Jan 2017 18:12:36 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 608FF5F47A for ; Mon, 16 Jan 2017 18:12:35 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 22565E587C for ; Mon, 16 Jan 2017 18:12:28 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7387F25285 for ; Mon, 16 Jan 2017 18:12:26 +0000 (UTC) Date: Mon, 16 Jan 2017 18:12:26 +0000 (UTC) From: "Antonenko Alexander (JIRA)" To: issues@ambari.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (AMBARI-19540) Possibly too frequent calls to stack advisor as user changes sliders MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 16 Jan 2017 18:12:40 -0000 [ https://issues.apache.org/jira/browse/AMBARI-19540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antonenko Alexander updated AMBARI-19540: ----------------------------------------- Attachment: AMBARI-19540.patch > Possibly too frequent calls to stack advisor as user changes sliders > -------------------------------------------------------------------- > > Key: AMBARI-19540 > URL: https://issues.apache.org/jira/browse/AMBARI-19540 > Project: Ambari > Issue Type: Bug > Components: ambari-web > Affects Versions: 2.5.0 > Reporter: Vivek Ratnavel Subramanian > Assignee: Vivek Ratnavel Subramanian > Fix For: 2.5.0 > > Attachments: AMBARI-19540.patch, AMBARI-19540.v0.patch, AMBARI-19540.v1.branch-2.5.patch > > > As you can see 3 calls are made while changing from 1024 to 2048 and similarly 3 calls when coming back to 1024. > Beyond performance concern, multiple calls have a functional issue. The call includes previous value of the changed property - see the values. I would have expected the old value to be the value that was the original/saved value. However, it is wherever UI makes the stack advisor calls. > [root@smq1-1 stack-recommendations]# find . -name services.json | xargs grep -A 3 changed > ./55/services.json: "changed-configurations" : [ { > ./55/services.json- "type" : "yarn-site", > ./55/services.json- "name" : "yarn.scheduler.minimum-allocation-mb", > ./55/services.json- "old_value" : "1024" > ./56/services.json: "changed-configurations" : [ { > ./56/services.json- "type" : "yarn-site", > ./56/services.json- "name" : "yarn.scheduler.minimum-allocation-mb", > ./56/services.json- "old_value" : "1280" > ./57/services.json: "changed-configurations" : [ { > ./57/services.json- "type" : "yarn-site", > ./57/services.json- "name" : "yarn.scheduler.minimum-allocation-mb", > ./57/services.json- "old_value" : "1792" > ./58/services.json: "changed-configurations" : [ { > ./58/services.json- "type" : "yarn-site", > ./58/services.json- "name" : "yarn.scheduler.minimum-allocation-mb", > ./58/services.json- "old_value" : "2048" > ./59/services.json: "changed-configurations" : [ { > ./59/services.json- "type" : "yarn-site", > ./59/services.json- "name" : "yarn.scheduler.minimum-allocation-mb", > ./59/services.json- "old_value" : "1792" > ./60/services.json: "changed-configurations" : [ { > ./60/services.json- "type" : "yarn-site", > ./60/services.json- "name" : "yarn.scheduler.minimum-allocation-mb", > ./60/services.json- "old_value" : "1280" -- This message was sent by Atlassian JIRA (v6.3.4#6332)